You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #10

  Asixandur Aug 28, 2012 at 04:29 UTC - 0 likes

  Probably the original author doesn't play wow anymore. I'll try to fix that or to make a similar type of add-on. I'll keep you updated.

• 

  • Reply
  • #9

  khoinoor Mar 02, 2011 at 02:13 UTC - 0 likes

  on today the option still reset after login, /ReloadUi, zone change and similar. Any chance to have a fix in short time? Very awsome addon but very useless if I have to bear in mind to check option before each pull or wen close to do an achievement, and anyway keep finger crossed hoping option wont reset on the fly.

• 

  • Reply
  • #8

  sajmoon Nov 17, 2010 at 01:24 UTC - 0 likes

  Options are resetting every few logins/zone-ins/reloadUIs

• 

  • Reply
  • #7

  RVCA18 Nov 01, 2010 at 03:16 UTC - 0 likes

  Well, take care and good luck. I liked the addon, but with the issues and the unwillingness to accept any help, I'll probably just end up writing a new mod that will work out to my expectations. I already looked at the new update you pushed out and it really does need a lot of work.

  Wish you the best!

• 

  • Reply
  • #6

  Blamdarot Oct 31, 2010 at 23:04 UTC - 0 likes

  Thanks RVCA. No offense taken. And I hope you aren't offended that I won't even look at your code. I have this thing about doing it myself. :)

  The wait function is needed. It's in there to fix a bug. On slower machines, the screenshots are taken too fast and miss the event. So, that will be left in.

  I already fixed the bug where the options fail to save. I also fixed the bug where the default options not loading for first time users. No one reported it, but I found it while testing.

  Thanks for letting know about the "SCREENSHOT_SUCCEEDED" event. I'll explore that.

  Hiding the UI. Do you mean that you expect my mod to change the way screenshots are taken when the player presses the "Print Screen" button? I have no desire to change that.

  Exalted only for rep milestones sounds good. If I have time today to get that in I will, but I'm really hoping to get a fully functioning release out today and I'm way behind where I hoped to be at this point. Too much baby. :)

  Thanks again for letting me know about the issues.

• 

  • Reply
  • #5

  RVCA18 Oct 31, 2010 at 22:44 UTC - 0 likes

  Well the options weren't saving for starters. Also the dreadful lag that the wait function would cause (which isn't needed by the way). If you look at the code I provided for you, you can see that I completely removed the wait function. Also, the issue you have with showing the UI after it's hidden, which in turn makes the player have to press the escape key was fixed. Another thing that I see players were complaining about was the ability to select exalted only for reputation screenshots.

  Wait Function and HideUI

  The removal of the wait function reduces screenshot lag and by adding the SCREENSHOT_SUCCEEDED event you can fix your hide ui issue as well. That right there is two birds with one stone.

  Example:

  function AchScreens_OnLoad(self)
          ...
  	self:RegisterEvent( "SCREENSHOT_SUCCEEDED" ); -- fires when Screenshot is successful
  	...
  end
  
  function AchScreens_OnEvent( self, event, ... )
          ...
  	elseif( event == "SCREENSHOT_SUCCEEDED" ) then
  		UIParent:Show()
          ...
  	end
  end
  
  function AS_take_screenshot(visibility)
  	if (visibility == false) then
  		UIParent:Hide()
  	end
  	Screenshot()
  end
  

  HideUI Button in Options

  I also noticed the actual HideUI button didn't really do anything. Hitting the normal screenshot button didn't actually hide the UI when taking screenshots. The workaround would have to do with bindings. You would have two bindings, one for the default Blizzard UI to handle taking screenshots (UI is shown) or the Addon to handle screenshots (UI is hidden) when that option is selected.

  The code for this is a little bit long so I'll omit that.

  Exalted Only Option

  Simple fix, add a button to the xml file and adjust a couple of pieces of code. Most important part would be,

  function AS_chat_msg_system( msg )
  	if (AS_settings.AS_ss_reps_exalted_only) then
  		if (string.find( msg, "You are now Exalted with")) then
  			AS_take_screenshot(true);
  		end
  	else
  		if( string.find( msg, "You are now")
  		and string.find( msg, "with") ) then
  			AS_take_screenshot(true);
  		end	
  	end
  end
  

  "Thank you RVCA for your efforts. I went ahead and did the work myself: how can I learn it if someone else does it for me?"

  I just love writing code and helping others out, please don't take any offense! :D

• 

  • Reply
  • #4

  Blamdarot Oct 31, 2010 at 18:48 UTC - 0 likes

  Thank you RVCA for your efforts. I went ahead and did the work myself: how can I learn it if someone else does it for me? :)

  If you let me know what issues you found, I'll make sure I get those fixed, too.

• 

  • Reply
  • #3

  RVCA18 Oct 28, 2010 at 19:01 UTC - 0 likes

  Hi Blamdarot,

  If you need some help I'm will to work on Achievement Screenshotter. I'm already making some changes to get it working for 4.0 and fix a couple of issues that have existed for a while.

  Test it out and let me know what you think.

  Last edited Oct 31, 2010 by RVCA18
• 

  • Reply
  • #2

  Blamdarot Oct 16, 2010 at 21:15 UTC - 0 likes

  Thanks for the message. I haven't gotten any funding and I'm currently caring for my newborn daughter.

  I'm hoping that she will let me get some work done on my mods soon. I'd like to have them ready for Cataclysm.

• 

  • Reply
  • #1

  gogoraider Oct 16, 2010 at 16:19 UTC - 0 likes

  Please update for 4.0

  Is this addon still in development? I don't know of any specific problems, but I know this addon won't load unless you select "Load out of date addons." Are you still active on this project? Have you received sufficient donations / praise to make this worthwhile for you?

  Thanks for all your hard work!