Advanced Trade Skill Window

159 - GetItemInfo error in 5.2.0

What steps will reproduce the problem?
1. Open ATSW
2. Mouse over anything in the open window
3.

What is the expected output? What do you see instead?

Error message pops up.

What version of the product are you using?

10.2

Do you have an error log of what happened?

Date: 2013-03-06 05:54:06
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\AdvancedTradeSkillWindow\atsw.lua line 2339:
   Usage: GetItemInfo(itemID|"name"|"itemlink")
Debug:
   [C]: GetItemInfo()
   AdvancedTradeSkillWindow\atsw.lua:2339 ATSW_DisplayTradeskillTooltip()
   [string "*:OnEnter"]:2:
      [string "*:OnEnter"]:1
Locals:
(*temporary) = nil

Please provide any additional information below.

User When Change
Aoife Mar 06, 2013 at 13:57 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of jamak jamak Apr 01, 2013 at 07:28 UTC - 0 likes

    Hi,

    I did a small fix and posted it on curse.com (comment #1833). It seems to be working fine judging from the feedback. Maybe you could check it out too? In atsw.lua:

    Line 2339: change GetItemInfo(atsw_necessaryitems[i].link) to GetItemInfo(atsw_necessaryitems[i].name)

    Line 2340: change GetItemQualityColor(itemRarity) to GetItemQualityColor(itemRarity or 0)

    Hope it helps.

    Cheers.

    Last edited Apr 02, 2013 by jamak

    Always treat others at least as well as you would like others to treat you. And remember, if others treat you badly and you respond by treating others badly too, then you are no better than they are. God will judge them by their deeds and not yours, and God will judge you by your deeds and not theirs.

  • Avatar of Aoife Aoife Mar 20, 2013 at 13:24 UTC - 0 likes

    @Hangen_Doomhammer: Go

    I updated to ver 10.3 and the bugs are still there. I've switched to Skillet; not my favorite layout but it has all the info for the MoP cooking and it works.

    ~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~ Aoife Divine Alliance of Mok'Nathal
  • Avatar of Hangen_Doomhammer Hangen_Doomhammer Mar 20, 2013 at 13:15 UTC - 0 likes

    As of 5.2.0 build 16650 the GetTradeSkillReagentItemLink is broken and always returns nil. source

    1579: local reagentLink = GetTradeSkillReagentItemLink(i,j);
    ...
    2339: local _, _, itemRarity=GetItemInfo(atsw_necessaryitems[i].link)
    

    A temp fix could be to replace line 2339 with:

    2339: local itemRarity=1
    
  • 3 comments

Facts

Last updated
Apr 07, 2013
Reported
Mar 06, 2013
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees