Broker_Garbage

13 - Auto Delete destroying quest items

A problem with the addon deleting quest items recently... it took me forever to do one quest because I was low on bag space and it was deleting the twenty bear asses I was collecting every time I picked up anything else. It just now deleted the mimic octopus (a green quality quest item for rep with Nat Pagle when you're fishing sometimes) to take the white quality fish I'd caught. I often fish with full bags so that it only picks up fish I already have, leaving the trash and unwanted fish, and having it delete necessary items is kind of a bummer...

They hadn't been added to any list; I just got the mimic octopus for the first time about five minutes ago.

User When Change
ckaotik Oct 27, 2012 at 20:34 UTC
ckaotik Oct 24, 2012 at 05:57 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of enewhouse enewhouse Oct 29, 2012 at 16:11 UTC - 0 likes

    Hello,

    First of all, thank you for a wonderful mod. I really appreciate that you wrote this.

    Second, I would like to make a feature request. I'm wondering if you could please make the broker garbage configuration window movable.

    Like lots of folks, I use the adibags addon to organize my bags. When I try to add items to the auto-sell list, sometimes adibags has them underneath your window, and thus I can't drag them over to the autosell list. If it were possible to move your window a little to the left, the problem would be solved.

    Thanks for considering this. Eric

  • Avatar of ckaotik ckaotik Oct 27, 2012 at 20:34 UTC - 0 likes

    Awesome :D

  • Avatar of Azaram Azaram Oct 26, 2012 at 14:16 UTC - 0 likes

    Looks like it worked. I was just fishing with several quest item collections in my bags, and got 'I can't carry anymore' when I caught something that wouldn't stack. Yay! :D

  • Avatar of ckaotik ckaotik Oct 26, 2012 at 07:12 UTC - 0 likes

    Well, those messages did help somewhat ;) Besides, the LootManager should spew out less debug messages. So if you ever need it, BG's debug setting is in the first tab on the config pane, while BGLM's is in the third (LootManager settings) tab :)

    Let's keep those fingers crossed we won't need debug output for a while!

  • Avatar of Azaram Azaram Oct 26, 2012 at 00:10 UTC - 0 likes

    Heh. If it'd deleted something major, I'd use the restoration, but it's only deleted quest items and random stuff I wanted but didn't need. The harvest festival fruit I literally had for years, because it was a 75% health/mana restore, (3% per second for 25%) and thus too cool to use mostly. I mentioned the extra comma mainly as 'that wasn't my typo', just to make sure.

    Sorry about the wrong messages; they were the only 'show debug' stuff I found in there. If you can tell me where the loot manager ones are I'll turn those on. I just installed topfit so I could read the other stuff; every time I did anything with my inventory, it literally filled the chat log, as far as I could scroll back. With topfit installed so those messages don't show, it leaves a few lines of space.

    No problem on helping test; I do tech support for a living, so being helpful is an occupational hazard. And I'm not going to give you a hard time over this free application you've given me. (Installs new alpha) Will be the morning before I can do any testing, though.

    Last edited Oct 26, 2012 by Azaram
  • Avatar of ckaotik ckaotik Oct 25, 2012 at 20:07 UTC - 0 likes

    Okay, apparenty you enabled Broker_Garbage's debug messages which are useful but don't enlighten me on what the LootManager does (which has its own debug messages) :(

    Apparently, BG tried to delete an item in bag 0 (your backpack), slot 1 (i.e. the first thing in your bags). It didn't delete though, because itemIDs didn't match (luckily!). Dont mind the additional comma.

    Error! Item to be deleted is not the expected item. 
    I got these parameters:, 19994, 0, 1 (Note the comma after the colon)
    

    When you don't have TopFit active, it's not really an error but more an informational thing "Oh, yeah, I can't tell if this equipment item is useful or not. Let's just assume it's cool."

    Thanks a whole lot for being so enduring in testing this ;) I suggest you make use of Blizzard's item restoration service, though. It can restore multiple items so you'll get back your stuff! Only usable once every 30 days though "

    I just uploaded a new alpha - and guess what, in my tests it worked :D So, yet again, please check this new version out (and restore your items >.<). This might finally be the fix, so I hopefully won't need any further debug info from you ;) If it fails again (which I don't hope), come and spank me!

  • Avatar of Azaram Azaram Oct 25, 2012 at 13:12 UTC - 0 likes

    Yeah, the alpha killed the cindergut peppers for the quest of the same name. I didn't have the debug messages on, unfortunately.  I turned off Arkinventory so I could see what was in which bags (Gha, this interface is fugly... and tiny! :P ) and it was definitely NOT in my first bag/backpack. That one is full of the random stuff I'm keeping, like darkmoon tokens and crated artifacts. I installed Topfit to try and cut down on the spam from the errors a bit so I could see more of what was going on. Nothing was showing on the LDB tooltip to delete.

    (goes back up to spank monkies for the same quest)
    I had four bag spaces open, I picked up two items from a mass kill, and it deleted the harvest fruit I've had for years. :P (from the harvest festival. Kept them because they were too good to use, mainly. And it left me with three spaces open.
    Messages:

    Updating cache for 79864 , cindergut pepper
    Updating cache for 86436 , Beautiful Brooch
    Harvest Fruit x19 has been deleted.
    Bag update, 2
    Bag update, 3
    Bag update, 0
    Bag update, 2
    Error! Item to be deleted is not the expected item.
    I got these parameters:, 19994, 0, 1 (Note the comma after the colon)
    Bag update, 3
    (A bunch of 'quality too high and not junk listed', some 'item has zero value', )
    Disable, 1, 19994. (19994 is the code for harvest fruit, according to wowhead)
    (A bunch more 'quality too high and not junk listed', some 'item has zero value', then the amount of cash I'd looted)

    I now have three bag spaces open, going to kill the same five monkies (who respawned while I was typing this) and see what happens.

    Killed and looted, got two more of the cindergut peppers and 'dingy plate shoulderpads' a gray item. No deletions;
    Bag update, 2
    Bag update, 2
    Bag update, 0
    Bag update, 0
    More 'quality too high' and 'item has zero value'.
    Update count, 218, 79864
    A few more 'quality/zero value'
    Enable, 1, 90750 (the gray shoulders)
    More quality/zero value,
    The cash I looted.
    (Two bag spaces open now)

    Need one more pepper so I'll wait till they respawn, and resmack them.

    (I moved something to get the two spaces together so I could see what happened, and got:
    bag update, 4
    bag update, 4
    Disable, 401, 32864 (the commander's badge I moved, from netherwing quests)
    And bunches of quality/zero.

    Killed them, looted, pretty much the same as above. Updated the cindergut ID, updated the mote of harmony I got, everything else quality/zero.

    It did definitely delete some things when I had bag space to have carried all I looted. I had four spaces, looted two things, it deleted something random and left me with three spaces free.

    Last edited Oct 25, 2012 by Azaram
  • Avatar of Azaram Azaram Oct 24, 2012 at 23:42 UTC - 0 likes

    Whoops. :) I don't actually know where the items were; I use Arkinventory for bag management which gives one big bag instead of a load of little ones, plus auto sorting (All my soulbound gear in one section, all the stuff I have marked as 'keep' or 'archaeology' in a couple of others, etc)

    Will try it quickly, but need to leave for work in a few, so it'll be thursday morning before I can try it more in detail.

    Re lua errors: I have Swatter, that comes from the Auctioneer addon to catch them. There haven't been any related to BG that I've noticed, though.

    Re the upvote; oops. I thought it was 'I like this', not 'the problem's fixed'...

    Last edited Oct 25, 2012 by Azaram
  • Avatar of ckaotik ckaotik Oct 24, 2012 at 19:23 UTC - 0 likes

    I just pushed another alpha version, mind checking that one out?

    As far as I can tell now this is what might have happened: BG didn't find any deletable items in your inventory. You said you set it to only drop greys so you probably had none left in your bags. However, I forgot to add a little check to my code, so BGLM would delete whatever came first in that list - even if you did not see any item at all. (BG keeps track of your complete inventory, so even items not visible in the tooltip are still recorded) I added that check now though ;)

  • Avatar of ckaotik ckaotik Oct 24, 2012 at 14:49 UTC - 0 likes

    Okay, so I think I might have spotted the issue. Won't be able to fix it until I get home though so ... I suggest you disable auto destroy until I get out the update. If your LDB says you have no junk, BGLM will most likely delete a random item >.<

Facts

Last updated
Oct 27, 2012
Reported
Oct 24, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees