You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #88

  neaves Jun 28, 2010 at 20:21 UTC - 0 likes

  Thanks for the comments all!

  xtoq:
  LDB is on the request list, I think...if not I'll add it. I have two crippling bugs to address when I can find time. It might happen after that.

  ckaotik:
  -Thanks for the code check... wish it was prettier! I'll look at that line. As for ACTION_BAR_CHANGED, it's there for managing the shaman totem bars; I might disable the event on-load for non shamans.
  -Pets use local translations for detecting their type; I'll check other addons, to make sure I got the right word for "Beast", or whatever it's supposed to be
  -I want to refactor how/when suggestions are built, which should fix the memory (and CPU) complaints. There is way too much garbage collection going on currently.
  -I think most mana users get Prayer of Spirit, just because i didn't want to separate "MP5 Casters" and "Spirit Casters". Exceptions would be melee players (enhancement shamans, ret paladins, hunters). Holy paladins should get Prayer of Spirit, not because it's the right decision, but because that was easier to architect.

• 

  • Reply
  • #87

  ckaotik Jun 28, 2010 at 12:44 UTC - 0 likes

  Another point: BuffBroker uses lots and lots of memory. While idle and solo, it's about 2.5MB, which is quite much. But when in a group (doing random dungeon, for example) I had spikes of up to 10.5MB - definetely WAY too much.
  Checking your group every 2-5 seconds should be fine, for example. COMBAT_LOG_EVENT could probably be used, instead of the unfiletered one, as well as having a pre-check if it's even a change we're interested in (don't care about people in Dalaran cooking, do we?). What I can't figure out is why you need ACTIONBAR_SLOT_CHANGED ^^
  I suppose with every event that fires, you recreate all your tables etc. no matter if it's even needed. I had a similar issue with Broker_Garbage, but caching solved many problems for me. Though the only thing you could cache is the scanned players plus their specialties (skilled wisdom, or whatever), but I think you already do that...

• 

  • Reply
  • #86

  ckaotik Jun 28, 2010 at 11:42 UTC - 0 likes

  I noticed again, that sometimes BB doesn't buff pets. The specific case: My disc priest, 2/2 imp. fortitude, (not) buffing the hunter cat (don't know their talents, of course).

  Also, it might be better to buff spirit to any mana class. Sure, hunters, shamans and paladins don't get much out of it. But sometimes it matters. But I guess that's one part one could argue a lot about ;)

  Third, I had a peek at your code and (probably) found a copy-paste-error ;) BuffBroker.lua line 4181: "and (spellName == BuffBroker.Constants.SpecSpells.Primary or spellName == BuffBroker.Constants.SpecSpells.Secondary then" - you had Secondary twice.

• 

  • Reply
  • #85

  xtoq Jun 26, 2010 at 17:19 UTC - 0 likes

  I realize now that the "broker" part of the name refers to brokerage, not LDB (yes I should have read the FAQ first...). But would you consider adding LDB support? I think that would make this just about perfect. Thanks for the great mod regardless!

  Last edited Jun 26, 2010 by xtoq
• 

  • Reply
  • #84

  neaves Jun 23, 2010 at 17:44 UTC - 0 likes

  Thanks for the extra detail, ckaotik. I won't have time in my schedule to address that soon, but I have an idea how to reproduce/test/fix. My current implementation is to get notified when a greater spell is active (ala the error message), and skip that player as long as the "stronger version" remains active.

  in-combat is bothersome. I suspect in-combat texture changes won't be allowed, which means some other indicator is necessary to hint when to push the button (alpha change, highlight, overlay, etc). Beyond that, changing the spell cast when the button is clicked SHOULD be possible. "Soon" :)

• 

  • Reply
  • #83

  ckaotik Jun 20, 2010 at 11:10 UTC - 0 likes

  I still have BuffBroker getting stuck on buffing a lot. What I mean by that: I enter a LFD group, start buffing ... and at some point, BB can't buff - a stronger spell is already active. This error came up a lot more often in previous releases, but is still annoying as I can't even rebuff my own buffs (because, of course, he still wants to buff that person with the stronger buff).
  One suggestion I have: If you can't find this status automatically, maybe enable the user to skip this one buff? I imagine it like this: You would right-click the icon and BuffBroker would then ignore that player+buff combination for a) a certain amount of time (e.g. 5min) or b) the duration of that buff on that player.
  Also, it would be quite neat to have BB show an incombat spell, e.g. battle shout for warriors. I don't know if the UI would let you show/hide the BB frame incombat depending on the buff status, but even if it doesn't, one could use the BB icon for refreshing those combat spells infight.

• 

  • Reply
  • #82

  neaves Jun 17, 2010 at 16:19 UTC - 0 likes

  Quote from Azmak:

  Do I type it when I am missing a buff but BuffBroker does not want to rebuff it? Do I also type it when I manually rebuff and it's at 30 minutes then BuffBroker wants to rebuff at 29 or 16, like before?

  yep :)

• 

  • Reply
  • #81

  AZMAK Jun 17, 2010 at 00:14 UTC - 0 likes

  Exactly when am I supposed to type that command? Do I type it when I am missing a buff but BuffBroker does not want to rebuff it? Do I also type it when I manually rebuff and it's at 30 minutes then BuffBroker wants to rebuff at 29 or 16, like before? So I type that right after BuffBroker pops up?

  I will be eating dinner soon so between that and waiting for this behavior to happen again it may be a bit before I get back to you.

  Last edited Jun 17, 2010 by AZMAK
• 

  • Reply
  • #80

  neaves Jun 16, 2010 at 23:52 UTC - 0 likes

  The current buff priority is:

  Self Buffs
  Raid Buffs
  Class Buffs
  Single-Target Buffs

  When forms were added, they got lumped into Self buffs; I'm not sure that was the right decision. It's something I'll revisit before 1.7.0.

  Could you "print suggestions" and get some screenshots when this happens, Azmak? Typing "/bb dumpSuggestions" into the chat frame should do the trick. It sounds like you're consistently reproducing an interesting bug...but I'll need more detailed information to properly troubleshoot :)

• 

  • Reply
  • #79

  AZMAK Jun 16, 2010 at 23:14 UTC - 0 likes

  I don't know what's going on but it's working now for some reason. VE buff that is.

  But now it is Inner Fire not working.

  I've been playing around with it for a while, buffing and click-off the buffs etc to see what it does or does not ask me to rebuff. Missing buffs that BuffBroker don't ask for seem to be random. And it seems to have something to do with buffing manually and/or using BuffBroker.

  I just got done saying below that for a couple hours VE wouldn't work in BuffBroker, then I logged for nap and came back later and I tried tests again and VE worked this time but not Inner Fire. I got Inner Fire to show up again only after I buffed myself with it manually. Then when I clicked it off, BuffBroker picked up on it. There's something quirky going on and this may be related to the problem I reported about BuffBroker wanting to rebuff too early on (random spell).

  Just a quick request if possible. Would there be any reason why you cannot put Shadowform at the end of the buffing queue? Sometimes I want to refresh my buffs but I don't necessarily need to be in Shadowform (helping out lowbie friend on quests etc). I actually hate being in Shadowform, hate how it looks so when I am helping friends, I don't use it.

  Thanks

  Last edited Jun 16, 2010 by AZMAK