Clash (encounter journal tweaks)

3 - Long instance names hide "next" button

What steps will reproduce the problem?

  1. Open EncounterJournal
  2. Select "Gate of the Setting Sun" (deDE: "Tor der Untergehenden Sonne")
  3. Can't see the "next" arrow as the text is so long, it moves out of sight.

What is the expected output? What do you see instead?

A shortened instance name would be awesome, e.g. "Tor der U. Sonne". It *just* fits in loot view but in instance or encounter view you can't read the full name, nor use the wonderful "next" arrow.

What version of the product are you using?

2

Please provide any additional information below.

I fixed this locally with this code added to Details.lua's Clash:StartupDetails, however it's not pretty, doesn't shorten intelligently and also doesn't use a different length for loot view vs. instance/encounter view.

local shortenTitle = function()
local title = EncounterJournal.encounter.info.encounterTitle:GetText()
	if title and string.len(title) > 25 then
		title = string.gsub(title, "%s?(.[\128-\191]*)%S+%s", "%1. ")
	end
	EncounterJournal.encounter.info.encounterTitle:SetText(title)
end
hooksecurefunc("EncounterJournal_DisplayInstance", shortenTitle)
hooksecurefunc("EncounterJournal_DisplayEncounter", shortenTitle)
  • Bildschirmfoto_2012-11-28_um_22.34.49.png
    Gate of the Setting Sun hides ...
User When Change
ckaotik Nov 28, 2012 at 21:37 UTC

Added attachment Bildschirmfoto_2012-11-28_um_22.34.49.png

ckaotik Oct 04, 2012 at 10:56 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated
Nov 28, 2012
Reported
Oct 04, 2012
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees