Dominos

33 - Support for Fizzwidget FactionFriend

"Support" might not be the best choice of words, Dominos already works perfectly together with FactionFriend

In Bongos3 I had added this:
- Right-click functionality to the reputation bar, so it pops up the FactionFriend context-menu (which allows you to quickly select another faction)
- Show FactionFriend tooltip when you hover over the reputation bar (which adds 'virtual' reputation after item hand-ins)

Of course these additional features only work if you have FactionFriend running, but won't cause any problems without it. Also the experience bar is unaffected.

I'll try to post a patch for Dominos here later, hopefully it will be added... :)

User When Change
Tuller Fri, 06 Nov 2009 21:24:28 Changed status from New to Fixed
Dracula Wed, 12 Nov 2008 11:21:31 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of Gondemare Gondemare Thu, 16 Jul 2009 01:26:34

    Dude's changes were spot on and they still work. This saved me much heart ache trying to get the original bar back and in the right position ^.^''

  • Avatar of Dracula Dracula Tue, 23 Dec 2008 03:27:32

    Perhaps not most elegant, but works like a charm ;)

    Add 'GFW_FactionFriend' to the OptionalDependencies of Dominos_XP.toc, and apply the changes below in file Dominos_XP\xp.lua:

    In XP:Load(), change the last few lines to

    	local click = CreateFrame('Button', nil, value)
    	click:SetScript('OnClick', function(frame, button) self:OnClick(frame, button) end)
    	click:SetScript('OnEnter', function() self:UpdateTextShown(true) end)
    	click:SetScript('OnLeave', function() self:UpdateTextShown(false) end)
    	click:RegisterForClicks("LeftButtonUp", "RightButtonUp")
    	click:SetAllPoints(self)
    

    Replace XP:OnClick() with the following:

    function XP:OnClick(frame, button)
    	if (button == "RightButton" and FFF_ReputationWatchBar_OnClick) then
    		self.sets.alwaysShowXP = false
    		self:UpdateWatch()
    		FFF_ReputationWatchBar_OnClick(button)		
    	elseif (button == "LeftButton") then
    		self:SetAlwaysShowXP(not self.sets.alwaysShowXP)
    		-- this will toggle fizzwidget's tooltip on or off
    		if (self.sets.alwaysShowXP) then
    			self:UpdateTextShown(false)
    		else
    			self:UpdateTextShown(true)
    		end
    	end
    end
    

    Replace XP:UpdateTextShown() with the following:

    function XP:UpdateTextShown(active)
    	if active or self.sets.alwaysShowText then
    		self.text:Show()
    	else
    		self.text:Hide()
    	end
    	
    	if (active and FFF_ReputationWatchBar_OnEnter and not self.sets.alwaysShowXP) then
    		FFF_ReputationWatchBar_OnEnter()
    	end
    	if (not active and FFF_ReputationWatchBar_OnLeave) then
    		FFF_ReputationWatchBar_OnLeave()
    	end
    end
  • 2 comments

Facts

Last updated on
06 Nov 2009
Reported on
12 Nov 2008
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.

Reported by

Possible assignees

Votes (Total: +3, Average: +3.0)