CurseForge.com

EPGPLootmaster

105 - Filters don't seem to work correctly

Besides tokens, which do work, it offers me everything else i shouldn't get. I realize cloth cannot be filtered for a warrior cause of cloaks and such, but leather, mail, wands, librams etc, i don't wanna see that crap.

local autopassTable = {
    ['One-Handed Axes']     = {'WARLOCK','MAGE','DRUID','PRIEST'},
    ['Librams']             = {'DEATHKNIGHT','WARRIOR','ROGUE','MAGE','PRIEST','WARLOCK','DRUID','HUNTER','SHAMAN'},
    ['Thrown']              = {'DEATHKNIGHT','WARLOCK','PALADIN','MAGE','DRUID','SHAMAN','PRIEST'},
    ['Idols']               = {'DEATHKNIGHT','WARRIOR','SHAMAN','MAGE','PRIEST','WARLOCK','HUNTER','PALADIN','ROGUE'},
    ['Crossbows']           = {'DEATHKNIGHT','WARLOCK','PALADIN','MAGE','DRUID','SHAMAN','PRIEST'},
    ['Plate']               = {'HUNTER','WARLOCK','SHAMAN','MAGE','DRUID','ROGUE','PRIEST'},
    ['One-Handed Maces']    = {'MAGE','HUNTER','WARLOCK'},
    ['One-Handed Swords']   = {'DRUID','SHAMAN','PRIEST'},
    ['Shields']             = {'DEATHKNIGHT','WARLOCK','ROGUE','MAGE','DRUID','HUNTER','PRIEST'},
    ['Two-Handed Maces']    = {'MAGE','HUNTER','ROGUE','WARLOCK','PRIEST'},
    ['Totems']              = {'DEATHKNIGHT','WARRIOR','ROGUE','MAGE','PRIEST','WARLOCK','DRUID','HUNTER','PALADIN'},
    ['Daggers']             = {'DEATHKNIGHT','PALADIN'},
    ['Two-Handed Swords']   = {'WARLOCK','SHAMAN','MAGE','DRUID','ROGUE','PRIEST'},
    ['Bows']                = {'DEATHKNIGHT','WARLOCK','PALADIN','MAGE','DRUID','SHAMAN','PRIEST'},
    ['Leather']             = {'DEATHKNIGHT','WARRIOR','PALADIN','HUNTER','SHAMAN','MAGE','WARLOCK','PRIEST'},
    ['Polearms']            = {'SHAMAN','MAGE','ROGUE','PRIEST'},
    ['Guns']                = {'DEATHKNIGHT','WARLOCK','PALADIN','MAGE','DRUID','SHAMAN','PRIEST'},
    ['Fist Weapons']        = {'DEATHKNIGHT','WARLOCK','PALADIN','MAGE','PRIEST'},
    ['Mail']                = {'DEATHKNIGHT','WARRIOR','PALADIN','WARLOCK','ROGUE','MAGE','DRUID','PRIEST'},
    ['Wands']               = {'DEATHKNIGHT','WARRIOR','PALADIN','HUNTER','DRUID','ROGUE','SHAMAN'},
    ['Staves']              = {'DEATHKNIGHT','ROGUE','PALADIN'},
    ['Two-Handed Axes']     = {'WARLOCK','ROGUE','MAGE','DRUID','PRIEST'},
    ['Sigils']              = {'PALADIN','WARRIOR','ROGUE','MAGE','PRIEST','WARLOCK','DRUID','HUNTER','SHAMAN'},
	['Relics']              = {}
}

local subTypeLocalizedLookup = {
    ['One-Handed Axes']     = 'Hitem:31071',    -- Grom'tor's Charge
    ['Thrown']              = 'Hitem:29211',    -- Fitz's Throwing Axe
    ['Crossbows']           = 'Hitem:28397',    -- Emberhawk Crossbow
    ['One-Handed Maces']    = 'Hitem:27901',    -- Blackout Truncheon
    ['One-Handed Swords']   = 'Hitem:28267',    -- Edge of the Cosmos
    ['Two-Handed Maces']    = 'Hitem:30093',    -- Great Earthforged Hammer
    ['Daggers']             = 'Hitem:30999',    -- Ashtongue Blade
    ['Two-Handed Swords']   = 'Hitem:27769',    -- Endbringer
    ['Bows']                = 'Hitem:31072',    -- Lohn'goron, Bow of the Torn-heart
    ['Polearms']            = 'Hitem:24044',    -- Hellreaver
    ['Guns']                = 'Hitem:31000',    -- Bloodwarder's Rifle
    ['Fist Weapons']        = 'Hitem:27747',    -- Boggspine Knuckles
    ['Wands']               = 'Hitem:25640',    -- Nesingwary Safari Stick
    ['Staves']              = 'Hitem:25760',    -- Battle Mage's Baton
    ['Two-Handed Axes']     = 'Hitem:32663',    -- Apexis Cleaver

    ['Totems']              = 'Hitem:50458',    -- Bizuri's Totem of Shattered Ice
    ['Shields']             = 'Hitem:31491',    -- Netherwing Defender's Shield
    ['Librams']             = 'Hitem:31033',    -- Libram of Righteous Power
    ['Idols']               = 'Hitem:38366',    -- Idol of Pure Thoughts
    ['Sigils']              = 'Hitem:40875',    -- Sigil of Arthritic Binding

	['Relics']              = 'Hitem:40875',    -- Sigil of Arthritic Binding

    ['Mail']                = 'Hitem:31214',    -- Abyssal Mail Greaves
    ['Leather']             = 'Hitem:31215',    -- Abyssal Leather Treads
    ['Plate']               = 'Hitem:31213'     -- Abyssal Plate Sabatons
}

i clearly see this in code (slightly modified by me to include leather and mail filters). so why is it still not auto passing on any of that, i still get popups for everything but tokens. also why do you use full Hitem:31213 instead if just ID and a better expression like ([^%s]+).*Hitem:(%d+)" which then would only expect to find a number, not a string for item ID.

although from lack of updates and ticket responses i have to wonder if this is being actively worked on anymore, it's still full of bugs, most annoyingly, bugging out the guild blizzard frame.

User When Change
mysticalos Apr 07, 2011 at 19:00 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of mackatack mackatack Apr 12, 2011 at 18:07 UTC - 0 likes

    Also, what's your localisation?

  • Avatar of mackatack mackatack Apr 12, 2011 at 18:07 UTC - 0 likes

    Thanks for your bugreport.

    You're correct that this addon is not being worked on actively anymore. I try to keep the addon working bugfree, but im currently not adding any more features.

    About the guild frame bugging out, that's a known bug for EPGP, not EPGPLootmaster. You could ask on the EPGP forums what's taking so long.

    It seems the automated lookup for localised item subtypes is buggy, which has always worked. I might switch to LibBabble for localised item subtypes, so this code can be removed.

    I just need you to verify that it's not autopassing BoP items, BoE items are never autopassed. That could be a reason for you getting the popup.

    Thanks for the coding suggestions, i will take them into consideration.

  • 2 comments

Facts

Reported
Apr 07, 2011
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees