CurseForge.com

EPGPLootmaster

28 - Find a to fix the GP awarding bug when players are out of range.

Every now and again, we have an issue with the addon not taking GP away when the player is given the loot item, requiring us to manually deduct the GP. Happens at least 2+ times per raid... usually more like 4-5 or more.

At first, I thought it was just because the people were getting too far away from me - IE, jumping through the portal at the end of the Naxx wing. But it happens when they're standing right next to me, too. Any idea what's causing this, and how to fix it?

Another thing I wanted to do was ask for an addition to the addon - the ability to export the list into the raid chat/notepad/etc, and/or for everyone to be able to type, for example, /lm list and see their specific position on the Priority List. (And heh, I'll also put these into a ticket too. :D)

Anyway, fantastic addon, and thank you for continuing work on it! We'll keep using it as long as you keep it functional! It's fantastic!!

User When Change
mackatack Jun 19, 2009 at 10:27 UTC Changed status from Replied to Fixed
mackatack Feb 24, 2009 at 22:30 UTC Changed name from Defect and Request/Enhancement to Find a to fix the GP awarding bug when players are out of range.
Syri Feb 24, 2009 at 18:10 UTC Changed status from Waiting to Replied
mackatack Feb 24, 2009 at 08:29 UTC Changed status from New to Waiting
Syri Feb 23, 2009 at 18:15 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of mackatack mackatack Jun 19, 2009 at 10:26 UTC - 0 likes

    I've finally made a fix for this, but only when master looting has been enabled. It has been added to the EPGP repository. Version epgp-5.4.11 will probably have this fix implemented. Keep you eyes open for this version.

    For those interested: Current implementation of the fix is as follows. The master looter calls GiveMasterLoot(lootslotID, candidateID) when he wants to distribute an item to a player. This patch hooks that function and remembers who the ML tried to send a specific item to. Even though the ML doesn't get the 'Player X receives Item Y' message, he still gets the LOOT_SLOT_CLEARED event. While this is normally used to redraw the UI, we can now use it to determine who got the item using the GiveMasterLoot() cache. If a 'Player X receives Item Y' message isn't received within 5 seconds the patch will automatically emulate a message locally. Locally means: only the ML will receive this message, the rest of the raid will still have incorrect data in addons such as Headcount etc. However, on the ML client GP is now distributed correctly and Headcount registers all loot as expected.

    Enjoy!

  • Avatar of mackatack mackatack Mar 13, 2009 at 14:05 UTC - 0 likes

    Added a commandline operation for testing purposes:
    /lm emulate PlayerName [ItemLink]
    This will emulate a "Player receives [ItemLink]." message locally. Please try this when you encounter the naxx portal 'bug'. Please tell me your results. If this works as i expect i will properly integrate this function into the gui. Using this commandline function will also make the item register in HeadCount etc.

  • Avatar of mackatack mackatack Mar 05, 2009 at 09:38 UTC - 0 likes

    I don't expect this to be a problem, because if another addon would also start emulating the events EPGPLootmaster wouldn't know the difference from a real event and would not go in error state, thus not emulating the event itself.

  • Avatar of DarthVon DarthVon Mar 04, 2009 at 21:52 UTC - 0 likes

    I would be cautious of emulating events for other addons. If they were changed to handle the error state as well, there would be duplicate events.

  • Avatar of mackatack mackatack Mar 02, 2009 at 09:05 UTC - 0 likes

    Agreed, it's pretty easy to detect the client is in 'error state' because the local loot events are still fired. However since other addons also depend on the 'Player X receives Loot Y' messages i propose the following: Implement what DarthVon said, detect when the loot slot got cleared and add another item on the candidate popup to 'Force GP'. When one clicks that button it will do the following: Emulate a 'Player X receives Loot Y' by traversing all forms and calling the OnEvent functions, this will fix EPGP, EPGPLootmaster, HeadCount, CT_RaidTracker and all other addons that depend on this event. Once that event is called EPGPLootmaster will automatically set the GP using the regular eventhandler.

    Once this extra button has been fully tested i could work to a system that automatically detects when the client is in 'error state' and will no longer receive a loot message, allowing to automatically handle everything for you.

  • Avatar of DarthVon DarthVon Mar 01, 2009 at 22:50 UTC - 0 likes

    It's definitely Blizzard's fault and not this addon. It happens when the person is too far away, the assignment of loot isn't reported. EPGP itself has the same issue. I have never seen it happen when the person is standing right next to me while I'm looting, though. I would rather see Blizzard fix this, than have some convoluted fix to this addon that fails sometimes and makes things more difficult for me. Right now I can tell pretty easily when it's in a bad state (I have to "Discard Loot" since it's no longer in the loot window).

    In fact, when loot is assigned, you could remember to who and show a button that says "Force GP" or something like that. The button would only be available when in the error state, since the interface advances to the next item or closes when it detects the assignment properly occurring.

  • Avatar of mackatack mackatack Mar 01, 2009 at 17:16 UTC - 0 likes

    That's really blizz' fault then... sigh. I really hope i can fix this for you guys, it's pretty annoying.

  • Avatar of Syri Syri Mar 01, 2009 at 01:14 UTC - 0 likes

    Huh, I thought I mentioned this here, but I guess I forgot... it's not just when they're out of range when it happens - it happens when they're standing right next to myself and the mob corpse on occasion, too.

  • Avatar of mackatack mackatack Feb 24, 2009 at 22:28 UTC - 0 likes

    Well i can try to trap the local LOOT_SLOT_CLEARED events, see what item got looted and award the GP to the player you've last tried to hand the item to. This is however quite unsafe, for instance: you use the EPGPLM window to distribute the item and the receiving player's inventory is full. If you then for whatever reason decide to use the native window to hand the loot to someone else it will award the GP to the wrong person. I know chances are slim this will ever happen. I will try to detect this and present you a proper popup when it does happen. Please note that this will mean HeadCount or CT_RaidTracker still require manual registration as this will not provide a fix for those addons.

  • Avatar of Brelkin Brelkin Feb 24, 2009 at 21:08 UTC - 0 likes

    I have also seen this problem. I have noticed that I do not see the "Player X gets loot Y" message in my chat window every time this happens. Like Syri, I have to ask the person in vent "Please confirm you got loot X", manually credit the person with GP (by using the /epgp interface), then click on the "Discard Loot" button to get rid of the EPGPLootmaster window.

    Something that might help in resolving this problem is that the loot does disappear from the loot window, so obviously the game knows it's gone.

    This makes handing out GP a lot more complicated than it normally is, and really is the only main bug I've noticed with this mod. I truly love this mod, and have been bugging my guild members to install it since day one. It makes my LM job so much easier.

Facts

Last updated
Mar 30, 2012
Reported
Feb 23, 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees