Fishing Buddy

116 - Auto Lure often re-lures when it should not

What steps will reproduce the problem?
1. Enable Always Lure and Easy Lures
2. Use a Mastercraft Kalu'ak Fishing Pole (seems to happen more with that pole, not sure why)
3. Put Aqua-Dynamic fish attractors in your bag and no other lures
4. Fish as usual with double-click - FB will often get into a mode where it repeatedly applies lures, wasting them, when a lure is already attached.

What is the expected output? What do you see instead?
Should only apply the lure when there is no lure already on the pole.

What version of the product are you using?
1.0.1 - seems to have started happening in this version or a very recent one.

I don't claim to fully understand the luring spaghetti code, but here is a 2-line fix that seems to be effective:

*** FishingBuddy-old.lua      Sat Apr  2 23:43:58 2011
--- FishingBuddy.lua  Sat Apr  2 22:58:19 2011
***************
*** 1055,1074 ****
--- 1055,1076 ----
                        end
                elseif ( GSB("AlwaysLure") ) then
                        -- don't put on a lure if we've already got one
                        if ( tempenchant == 0 ) then
                                if ( not state ) then
                                        LastState, LastLure = FL:FindNextLure(nil, 0);
                                else
                                        LastState = state;
                                        LastLure = bestlure;
                                end
+                       else
+                         LastLure = nil -- oscarucb
                        end
                elseif ( state and bestlure and tempenchant == 0 and GSB("LastResort") ) then
                        LastState = state;
                        LastLure = bestlure;
                else
                        LastLure = nil;
                end
                DoLure = LastLure;
  
                if ( DoLure and DoLure.id ) then

User When Change
Sutorix Dec 22, 2013 at 19:46 UTC Changed status from Replied to Fixed
Hendo72 Jul 07, 2011 at 17:44 UTC
Sutorix Apr 27, 2011 at 02:09 UTC Changed status from Accepted to Waiting
Sutorix Apr 17, 2011 at 03:44 UTC Changed status from New to Accepted
oscarucb Apr 03, 2011 at 03:49 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of Sutorix Sutorix Jul 08, 2011 at 02:21 UTC - 0 likes

    Sigh. Yes, it's been incorporated. I'll keep digging.

  • Avatar of Hendo72 Hendo72 Jul 07, 2011 at 17:44 UTC - 0 likes

    Has this fix been incorporated into the addon?

    I am still having the same problem. I am using a regular fishing rod and shiny baubles.

    I was thinking that there might be an issue with the 'Lure already applied' check. (I don't know the exact variable name.)

    I think we've had this issue for quite some time now.

  • Avatar of Sutorix Sutorix Apr 17, 2011 at 03:47 UTC - 0 likes

    That looks like a possible fix (not sure why I never see it, but then it's been driving me crazy for weeks now!)

    Thank you! (You're in the about box :-)

  • 3 comments

Facts

Last updated
Dec 22, 2013
Reported
Apr 03, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees