Fishing Buddy

7 - Need new quest reward poles

I just got the new Bone Fishing Pole and it doesn't seem to be recognized. Looks like the POLES array needs to be expanded to add the new 3.1 poles:

http://www.wowhead.com/?items=2.20

User When Change
Sutorix Sat, 26 Dec 2009 04:28:55 Changed status from New to Fixed
SpareSimian Sat, 18 Apr 2009 23:08:30 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of SpareSimian SpareSimian Mon, 20 Apr 2009 23:09:17

    One also needs to check for "achievement_profession_fishing_journeymanfisher", the bone pole.

    if ( itemTexture and ( string.find(itemTexture, "inv_fishingpole") or string.find(itemTexture, "journeymanfisher") ) ) then

    If we go beyond two strings, I recommend a table scan.

  • Avatar of leavethisplace leavethisplace Sun, 19 Apr 2009 19:55:20

    I've just emailed Sutorix about how to fix the new poles not being recognised. To make it clear, this is not an issue with fishing buddy as such but an issue from Blizzard; they decided to change how items are named.

    FishingBuddy checks to see if you have a fishing pole in your main hand by looking to see if the texture has "INV_Fishingpole" within the items texture name. With 3.1 however, the texture names on the current poles is "inv_fishingpole" and unfortunately LUA can't do non-case sensitive string searches.

    To fix this (for advanced users ONLY) open the LibFishing-1.0.lua and find line 170 - BELOW line 170 ADD:

    itemTexture = itemTexture:lower();

    At line 174 (previously 173 before the above change) REPLACE WITH

    if ( itemTexture and string.find(itemTexture, "inv_fishingpole") ) then
    - the case is important.

    Reload your UI and you're done.

  • 2 comments

Facts

Last updated on
26 Dec 2009
Reported on
18 Apr 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees