You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #19

  tiker Nov 03, 2011 at 12:42 UTC - 0 likes

  Thanks. I've made the same 2 fixes here so they should be fixed for the next version.

  Donations are always welcomed!
  BitCoins: 1Ah7kTcSccFnCYkek8XVnoAuj7kRH14EmH
  

• 

  • Reply
  • #18

  josephus_banks Nov 03, 2011 at 09:42 UTC - 0 likes

  Updated to check for the PallyPower addon.

  I know you won't be adding this to the official distribution, but I was able to easily add code to have the PallyPower addon triggered when I dismount. I merely added a GoGo_FillButton2 function that checks if the class is a paladin and is using the PallyPower addon. If those tests are true, it sets the macro to "/click PallypowerAuraBtn". I was sharing my discovery for other paladins to see that it is possible to modify the addon for setting another addon when we dismount (manually, at least).

  Here's the function I added:

  ---------
  function GoGo_FillButton2(button)
  ---------
  	if GoGo_Variables.Player.Class == "PALADIN" then
  		if (IsAddOnLoaded("PallyPower")) then
  			button:SetAttribute("macrotext", "/click PallyPowerAuraBtn")
  		end --if
  	end --if
  end --function
  

  After that, I simply added a GoGo_FillButton2(button) call to this in GoGo_PreClick, just before the first GoGo_Dismount() call.

  Last edited Nov 12, 2011 by josephus_banks
• 

  • Reply
  • #17

  josephus_banks Nov 03, 2011 at 04:30 UTC - 0 likes

  I just tried r320. The options frame is empty, and only Paladin Options is listed under GoGoMount. Oops? A quick look at the code didn't have a reason for the empty frame jumping out at me, so I guess it'll have to be looked at more closely.

  Edit: I found 2 overlooked things that fixed it: 1) Added the elseif for Paladin to GoGo_Panel_UpdateViews. And 2) Changed GoGo_Hunter_Panel to GoGo_Paladin_Panel on line 3150. As for that one, I did the same goof when I was starting to added the support, too. I also cloned the hunter function and changed Hunter to Paladin (and missed 1 occurrence).

  With those 2 changes, it changed my aura and pulled up my flying carpet. After removing my Charger from the exlude list (oops), it is pulled up with the aura change, as expected.

  Last edited Nov 03, 2011 by josephus_banks
• 

  • Reply
  • #16

  tiker Nov 03, 2011 at 02:27 UTC - 0 likes

  r320 has been posted with (hopefully) working Crusader Aura support.

  You'll have to enable it first since it's currently default to disabled.

  /gogo options in game, click "Paladin Options" under GoGoMount and enable it. Test it out and let me know if it works or not.
  

• 

  • Reply
  • #15

  josephus_banks Nov 03, 2011 at 00:16 UTC - 0 likes

  Fair enough on the dismount change, but I certainly didn't find one when I went looking. I guess I'll be writing my own addon for just that purpose. Everything else required me to manually click the aura change. But, like I said, that's cool. It'll still be nice to have Crusader automatically enabled when I mount up.

• 

  • Reply
  • #14

  tiker Nov 02, 2011 at 12:47 UTC - 0 likes

  I've already completed the code to cast the aura when mounting. The only left to do is create a new options window for Paladins only to enable / disable the auto casting of the aura. I'll hopefully have a version posted on this site here today for you to test.

  The reason I won't support auto casting when dismounting is because that goes beyond what GoGoMount was intended for. Druids and Shamans wanted to be able to resume previous shape forms and I've declined adding support for that as well.

  GoGoMount is intended to be a "find the best and fastest mount now and go" kind of mod. I believe there are other mods out there which will hook into mounted / dismounted status and will auto cast what you want.

• 

  • Reply
  • #13

  josephus_banks Nov 02, 2011 at 07:18 UTC - 0 likes

  That's a start. I'll try to keep an eye out for a test version and let you know how it goes. At least for now, setting an aura does not seem to effect any other cooldown. Of course, I've lost count of how many inconsistencies that are in WoW. And the devs seem to change some things for one patch and then revert them on the next patch making it even harder to predict what will and will not work. It's almost like there's no coordination behind the game programming.

  As for the aura setting when we mount or dismount, I had actually started adding support. I only got as far as adding the config panel, but that got overwritten when 4.2.20 was installed by Curse Client. I've seen an addon that would change outfits based on whether or not a player was mounted, so I just need to look through that code to see how it's detected. Adding similar detection would allow GoGoMount to either restore the previous aura or allow a defined aura be set for both mounting and dismounting. That's assuming the next patch doesn't remove that detection capability.

• 

  • Reply
  • #12

  tiker Nov 01, 2011 at 12:58 UTC - 0 likes

  The support for Crusader Aura didn't get completed because I lost access to the Paladin I had for testing.  If you're willing to test then I'll resume this request.

  I will only add support for casting Crusader Aura while mounting if it can be done with a single click.  (Meaning your macro casts both Crusader Aura and a mount with a single click.)  I will not try to resume previous auras when dismounting.

  Give me a day to put together a test version based on the macro you posted and let me know if it works.

• 

  • Reply
  • #11

  josephus_banks Oct 28, 2011 at 07:40 UTC - 0 likes

  First, I have been extremely happy with this addon since I found it. I greatly enjoy having a single button to mount/dismount and have the type of mount used be automatically picked for me. Love it.

  Now, I'd like request that the paladin aura support be re-added. The following macro allows me to set my aura and mount (or dismount):

  #showtooltip
  /cast [nomounted] Crusader Aura
  /cast [mounted] Retribution Aura
  /cast Summon Charger
  

  If this macro is working as intended, is it possible to add the aura capability to this addon, too? I assume this was not possible in the past, but I've seen things change (both good and bad) as this game gets updated. Maybe this is one of the good changes?

  Just to be clear, I did test this with other mounts, too. The only mounts that I did not test are those that aren't learned (i.e. mounts that require using an item in your inventory). However, I think a /cast and /use have always been allowed in the same macro. I could be mistaken, though.

  Edit: I did change the "/cast Summon Charger" to "/click GoGoButton" and discover that works, but the addon could allow a way to save/restore the aura used before mounting, or allow an easier way for paladins to change what aura they want to use when not mounted.

  Last edited Oct 28, 2011 by josephus_banks
• 

  • Reply
  • #10

  Pheelix14 Jan 21, 2011 at 16:20 UTC - 0 likes

  Bumping this Cause it would be nice to have in the addon.

  One of the problems with the Macro commands is that when you attack something from being mounted you have to manually swap auras. Having a option in the addon to select what aura to have on while mounted and not mounted would be nice to have so when you do attack something it will swap the auras.

  I'm not sure if this is something you can code into the addon or not but its a suggestion.