You must login to post a comment. Don't have an account? Register to get one!

• 

  • #4

  Dezyne Fri, 26 Jun 2009 01:18:13

  Awesome, I'll change that boss-check around then!

  The ML himself won't be reported to chat and neither will you yourself in the latest version I have local.

  I will implement the log feature as it sounds very viable! About the treasure looting, that indeed seems like a good solution. I don't think I can filter out these kinds of exceptions though, unless maybe I put it on a timer to see what they 'withdraw' from the loot window. I think I'll just add a "probably looted" output so it's up to the user himself to judge what's going on. But seriously, mining when you just killed a boss? That alone should get you negative DKPs :P

• 

  • #3

  Garkin Tue, 23 Jun 2009 16:44:53

  I have posted my first comment before I have looked to the code, so not all parts of my comment are accurate. I do apologize for that.

  As of UnitClassification(): I have tried that all bosses even those in instances are reported as "worldboss".

  As of chest loot: I have mentioned this because of the Keepers of Ulduar. None of them is killed, they are just defeated but stays alive. So it is not possible to check if one of raid members has targeted dead boss. But I still want to see that someone has looted chest before master looter did.
  My idea is: If player who have looted does not have in target dead boss or trash mob, it has to be treasure chest. I can imagine only those exceptions that could be probably filtered out: herb/ore gathering, opening Alchemist's Cache or similar containers and rogue's pickpocket.

  Some other ideas:
  - Do not report Master Looter (who is ML could be checked by GetLootMethod() function)
  - As it is considered to be rude to loot when someone in your raid is dead, it would be nice to check it.
  - Add some option to store log for later use (so you can give some negative DKPs ;-) )
  - Add option to anounce loots to some channel, not just to yourself

• 

  • #2

  Dezyne Mon, 22 Jun 2009 22:36:04

  Ew, the markup changed... Anyways! Sorry, missed your message! Thank you for your thourough analysis!

  • First things first - it does have "all announced functions implemented", since all I promised is that it tell you who looted when in a raid. Technically, that it does!
  • You suggest to enable/disable the addon hooking into the PLAYER_ENTERING_WORLD. Regarding performance, this would be more likely to decrease it rather than boost it. And regarding functionality, this would hardly change as the message is fired over the "RAID" CHAT_MSG_ADDON channel. So I do not believe this functionality would contribute. You can however add this to your local version of the AddOn, if you like!
  • Your second idea is pretty nice, I think I should add an option to support filtering like that. However, I would have that option disabled, myself, since there can be more 'ninja-looters' at one time. (edit: feature available in 1.2)
  • I do not believe UnitClassification can tell me whether it's a raid boss or not. From what I've understood it only checks world bosses, which by definition are outside and not in an instance. I have implemented a HP check though, which should be pretty solid and have the same performance/functionality results.
  • Checking for looting a treasure chest cannot be done. It can however be deducted to be likely, for instance when someone in the raid loots while at least one other person in the raid is targetting a dead boss which uses a chest for loot instead of corpse loot. This last could be checked through a pre-defined list or have it more dynamic by tossing the HP check in there in stead. I'll try it out to see!
• 

  • #1

  Garkin Wed, 10 Jun 2009 01:10:35

  I recommend that you change the status of files to alpha or beta as it does not have all announced functions implemented yet.

  I have a few ideas which would be nice to implement:
  1. Enable addon when in party/raid only
  2. Report the first looter only, filter out all other players who looted the same corpse. In the current state addon spams a lot.
  3. Report only when boss or his treasure chest is looted
  

  As for number 1 you can add something like this function:

  function iLoot_Lib:PLAYER_ENTERING_WORLD()
    local _, instanceType = IsInInstance()
    if instanceType == "party" or instanceType == "raid" then
      iLoot_Enabled = true
    elseif iLoot_Enabled then
      iLoot_Enabled = false
    end
  end
  

  As for number 2 there can be added some variable which stores a boss name. If content of this variable matches to name of looted boss, do not report it.

  I do not have good solution for number 3. While it is easy to say whether corpse belongs to boss (UnitClassification("unit") == "worldboss"), it is bit tricky to recognize treasure chest - to be honest I do not have any idea how to do it.