InstanceTime

11 - Immediate server disconnect when using loot links

What steps will reproduce the problem?
1. Type a chat meesage and
2.  shift-right-click loot item link from InstanceTime addon
3. send message

==========================================
What is the expected output? What do you see instead?
you are then disconnected from WoW

==========================================
What version of the product are you using?
3.71 but it has been occurring for many prior version

==========================================
Do you have an error log of what happened?
no error log generated

==========================================
Please provide any additional information below
The issue seems to be is that the SetItemRef call is given bad data from FreierGeist_IT_Loot["item"]
It seems the bad data is not handled by the SetItemRef in Blizzard_CombatLog.lua
and it falls through into the oldSetItemRef call in Itemref.lua

FreierGeist_IT_Loot["item"] link data entries in later versions begin with a space which causes the problem

A WoW bug has also been posted at http://forums.worldofwarcraft.com/thread.html?topicId=18031239644

--------------------------------
Possible fixes
1) Fix FreierGeist_IT_Loot["item"] link data entries to not include the leading space
2) [recommend] Change the code in FreierGeist_IT_ScrollBarSetItemLink
  From
-    link = FreierGeist_IT_Loot["item"][lootindex][lineplusoffset];    
-    link = string.gsub(link, "|cff9d9d9d|H", "");
-    link = string.gsub(link, "|cffffffff|H", "");
-    link = string.gsub(link, "|cff1eff00|H", "");
-    link = string.gsub(link, "|cff0070dd|H", "");
-    link = string.gsub(link, "|cffa335ee|H", "");
-    link = string.gsub(link, "|cffff8000|H", "");
-    link = string.gsub(link, "|h[%(%w*%)]|h|r", "");
-    SetItemRef(link, FreierGeist_IT_Loot["item"][lootindex][lineplusoffset], "InstanceTimeLootEntry"..NumberForItemLink);
  To
+    _, itemLink = GetItemInfo(FreierGeist_IT_Loot["item"][lootindex][lineplusoffset]);
+    if (itemLink) then
+        _, _, itemString = string.find(itemLink, "^|c%x+|H(.+)|h%[.*%]");
+        if (itemString) then
+            SetItemRef(itemString, itemLink, "InstanceTimeLootEntry"..NumberForItemLink);
+        end
+    end

User When Change
Dhana Mon, 21 Sep 2009 20:27:30 Changed status from Started to Fixed
Dhana Mon, 21 Sep 2009 20:27:24 Changed status from New to Started
Corelgun Sat, 04 Jul 2009 17:00:41 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of Lieandra Lieandra Sun, 05 Jul 2009 10:07:03

    Yeah. I read your ticket and decided to try it out because I didn't remember experiencing it. Something to note (as I did replicate your ticket) is that the link created by Instance time for the whisper is NOT really a link per se. I did disable ALL addons to see if that would make a difference.

    Look at this screen shot: Screenshot of Links

    Don't know if this tidbit would help you out a bit or not.

  • 1 comment

Facts

Last updated on
21 Sep 2009
Reported on
04 Jul 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees