Item Tooltip Cleaner

2 - Failed to shrink green text on zhTW client.

What version of the addon are you using?

4.3.2.20

What version and language of WoW are you playing in?

4.3.2 zhTW

What is the problem? What steps can I follow to reproduce it?

The addon failed to shrink green text on item's tooltip.
Like ”裝備:提高命中等級XXX點“.

It should (I HOPE) be "+XXX命中” .

Does the problem still happen when all other addons are disabled?

yes

If there is an error message related to the problem, please post it here:

no

Name Size MD5
GlobalStrings-zhTW-4.3.2.lua 582.1 KiB 627aa63ab968...
User When Change
Phanx Mar 05, 2012 at 03:47 UTC Changed status from Replied to Fixed
gwarp Mar 02, 2012 at 18:28 UTC Changed status from Waiting to Replied
Phanx Feb 29, 2012 at 01:30 UTC Changed status from Replied to Waiting
gwarp Feb 27, 2012 at 19:50 UTC Changed status from Waiting to Replied
Phanx Feb 27, 2012 at 00:53 UTC Changed status from Accepted to Waiting
Phanx Feb 26, 2012 at 02:10 UTC Changed status from Replied to Accepted
gwarp Feb 20, 2012 at 15:02 UTC Changed status from Waiting to Replied
gwarp Feb 20, 2012 at 15:02 UTC

Added attachment GlobalStrings-zhTW-4.3.2.lua

Phanx Feb 19, 2012 at 04:16 UTC Changed status from New to Waiting
Phanx Feb 19, 2012 at 04:09 UTC Changed description type from Plain Text to Markdown
gwarp Feb 17, 2012 at 07:37 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 8 comments
  • Avatar of Phanx Phanx Mar 03, 2012 at 21:56 UTC - 0 likes

    Yeah, that was the issue. The Blizzard global string doesn't match the example string you'd posted:

    提高%d點命中等級。  <-- ITEM_MOD_HIT_RATING
    提高命中等級%d點       <-- your original example
    

    All the same characters are in there, but not in the same order, which is why my search did not find the string. :p

    Anyway, I've gone through all of the ITEM_MOD_* strings from the current zhTW GlobalStrings.lua file you posted, and updated ItemTooltipCleaner accordingly, so the next version should correctly shorten everything in the zhTW game client. Please let me know if you notice any issues with the new version.

  • Avatar of gwarp gwarp Mar 02, 2012 at 18:28 UTC - 0 likes

    Hi,

    the hit rating text is ITEM_MOD_HIT_RATING = "提高%d點命中等級。"; I think it's THE text string on most items.

    So here are some examples. I suppose the strings starts with ITEM_MOD but no SHORT are the ones used in item tooltips.

    ITEM_MOD_CRIT_RATING = "提高%d點致命一擊等級。";
    ITEM_MOD_DODGE_RATING = "提高%d點閃躲等級。";
    ITEM_MOD_EXPERTISE_RATING = "使你的熟練等級提高%d點。";
    ITEM_MOD_HASTE_RATING = "提高%d點加速等級。";
    ITEM_MOD_HIT_RATING = "提高%d點命中等級。";
    ITEM_MOD_MASTERY_RATING = "使你的精通等級提高%d。";
    ITEM_MOD_RESILIENCE_RATING = "提高%d點韌性等級。";
    ITEM_MOD_PARRY_RATING = "提高%d點招架等級。";
    ITEM_MOD_SPELL_PENETRATION = "提高%d點法術穿透力。";
    
    Last edited Mar 02, 2012 by gwarp
  • Avatar of Phanx Phanx Feb 29, 2012 at 01:30 UTC - 0 likes

    My editor does not have any issues with the Chinese characters. My web browser is also able to render the file you posted without any problems. However, a search for the sequence "提高命中等級" (without quotes) did not find any matches in either program, which is the problem.

    The search patterns in Item Tooltip Cleaner come from the ITEM_MOD_* global strings. The global string for hit rating on an item is ITEM_MOD_HIT_MELEE_RATING, or "提高%d點近戰命中等級。" in the global strings file you posted.

    For comparison, here is Blizzard's global string for hit rating on an item, and the string you posted:

     提高%d點近戰命中等級。<-- pattern defined in GlobalStrings.lua
     提高命中等級%d點     <-- pattern you posted
    

    As you can see, these do not match. Feel free to search inside the file you posted for the string you see in-game, and give me the variable name (eg. ITEM_MOD_HIT_MELEE_RATING) if you can find it.

    However, if the pattern you posted is exactly what you see in-game, but does not exist in the global strings file, then the zhTW client is behaving differently from all other localized clients, which use the text defined in their localized global strings files.

  • Avatar of gwarp gwarp Feb 27, 2012 at 19:50 UTC - 0 likes

    First, you probably need a editor program which can change the code page, or the Chinese characters will not display correctly.

    I'm using UltraEdit-32, the working code page for this file is 950 (Traditional Chinese/Big5) or 936 (Simplified Chinese/GBK).

    Second, the word ”等級“ means rating. So that "命中等級“ is hit rating.

    White texts: 護甲=armor 智力=intellect 精神=spirit 力量=strength 耐力=stamina 敏捷=agility ---- Green texts: 命中=hit 致命=critical 精通=mastery 加速=haste 招架=parry 格擋=block 躲閃=dodge 熟練=expertise 韌性=resilience 法術穿透=spell penetration

    裝備:=Equip: 使用:=Use:

    PS. If you find the "extraterrestrial logograms” are too difficult to understand, I will happy to deal with it.

    reix8800[at]gmail.com

    Last edited Feb 27, 2012 by gwarp
  • Avatar of Phanx Phanx Feb 27, 2012 at 00:53 UTC - 0 likes

    Alright, I've looked throught the strings file, and I can't find any strings that contain "提高命中等級" like the one you posted. Could you give me a rough translation of the line you posted? That will help me find the actual string Blizzard is using.

  • Avatar of Phanx Phanx Feb 26, 2012 at 02:10 UTC - 0 likes

    I will look at this tomorrow and try to identify any new or changed patterns.

    If you have time, it would be awesome if you could hop over to the Localization tab and add some zhTW translations for the options panel, too. :)

  • Avatar of gwarp gwarp Feb 20, 2012 at 15:02 UTC - 0 likes

    Here you are!

  • Avatar of Phanx Phanx Feb 19, 2012 at 04:15 UTC - 0 likes

    Please follow the instructions here:

    http://www.wowpedia.org/Viewing_Blizzard's_interface_code#Extracting_interface_data

    to extract the current, localized GlobalStrings.lua file from your zhTW game client, and attach it to this ticket.

    Probably, Blizzard added some new patterns, but since I do not have access to a zhTW game client, I can't check it myself.

    Thanks!

  • 8 comments

Facts

Last updated
Mar 05, 2012
Reported
Feb 17, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees