LibBossEncounters-1.1

3 - CLEU not registering due to missmatch zone names

What steps will reproduce the problem?

  1. Include this Lib to your addon
  2. Go to an instance (tested with Stormwind Stockade)
  3. Nothing happens

What is the expected output? What do you see instead?

Expecting the Lib to register CLEU, instead it doesn't get registered due to not matching the instance name with the zone text.

What version of the product are you using?

1.1 r127-release

Do you have an error log of what happened?

No errors

Please provide any additional information below.

I did some quick testing in Stormwind Stockade and the LibBossEncounters-1.1.lua line 288 defines it following:

THE_STOCKADE = _G.GetMapNameByID(690),

and that is tested on line 152 with:

local zone_label = BossEncounters.zone_labels[_G.GetRealZoneText()]

If I run dump on GetRealZoneText() (line 152) inside The Stockade I get:

Dump: value=GetRealZoneText()
[1]="Stormwind Stockade"

and dump on GetMapNameByID(690) (line 288) I get:

Dump: value=GetMapNameByID(690)
[1]="The Stockade"

And they ain't the same so that is why the Lib doesn't register CLEU for me. I was thingking that maybe in the lib MapIDs should be changed into instanceIDs:

Dump: value=GetInstanceInfo()
[1]="Stormwind Stockade",
[2]="party",
[3]=1,
[4]="Normal",
[5]=5,
[6]=0,
[7]=false,
[8]=34

Changing detection from mapID to instanceID (arg 8 ) would fix the problem but the IDs ain't the same, it would take time to change every ID for without any automation.

User When Change
ahak May 01, 2013 at 13:48 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Reported
May 01, 2013
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees