4 - Modification
What is the enhancement in mind? How should it look and feel?
I would like to see the ability to dismount while flying added
I would also like to see the ability to mount/dismount with the push of a single key added
Please provide any additional information below...
I have modified MiniMount so that on first install it works exactly like originally designed but when you use the command /mm dwf it allows you to dismount while flying. It also warns you that this may be dangerous. Also I added /mm scm, which allows you to use single click mounting or to use a single hot-key to mount and dismount. I would like to submit the work I've done on it for your consideration for future releases but I've had trouble, untill now, figuring out how to submit it for some reason every time I try and log into curseforge.com useing IE8 I get an error. I have only modified the main.lua and localization.lua files and will post them soon on here. Thank you very much for your consideration in this matter. Please reply either way so at lest I know you got the message and thank you for an awesome add-on...
| Name | Size | MD5 |
|---|---|---|
| main.lua | 25.4 KiB | ffbbe84cf766... |
| localization.lua | 3.4 KiB | 28227be478e1... |
| readme.txt | 6.9 KiB | 82e17e9fb2fd... |
| User | When | Change |
|---|---|---|
| tberry7348 | Oct 03, 2009 at 10:27 UTC | Changed status from New to Invalid |
| tberry7348 | Oct 03, 2009 at 08:59 UTC | Added attachment readme.txt |
| tberry7348 | Oct 03, 2009 at 08:59 UTC | Added attachment localization.lua |
| tberry7348 | Oct 03, 2009 at 08:50 UTC | Added attachment main.lua |
| tberry7348 | Oct 03, 2009 at 08:49 UTC | Create |
- 1 comment
- 1 comment
Facts
- Last updated
- Oct 03, 2009
- Reported
- Oct 03, 2009
- Status
- Invalid - This was not a valid report.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
- Votes
- 0
- Reply
- #1
tberry7348 Oct 03, 2009 at 09:04 UTC - 0 likesI went ahead and modified the readme.txt file to reflect the changes as well to hopefully save you some time.... You may however wanna run spell-check on my changes to the localization.lua file because I know my spelling is atrocious. Once again thank you for an awesome add-on!!!
I forgot to note in the readme and above on other modification I made. I also added /mm settings wich shows the current settings for the entire mod.
for example my current settings are:
MiniMount: Version: 1.7.1
MiniMount: DefaultMode: Auto
MiniMount: PreferFlight: 1
MiniMount: scm: table: 168566d8
MiniMount: dwf: true
MiniMount: scm: true
MiniMount: dwf: true
MiniMount: scm: true
I needed this to figure out how to save my settings but I thought perhaps left in it could be useful in some way in future troubleshooting. I couldn't figure out how to make it show the use mount list setting or the default mount list settings so I remarked them out perhaps you can make that part work if needed. Also for the life of me I can't remember why I had it showing dwf and scm twice. I think at one time one reflected the variable that was saved and one reflected the variable that was currently being used wich I later merged into the same variable. looks like I got a little housecleaning to do if I can figure out how to I'll replace my original files I uploaded with a cleaner vertion shortly.
what was modified
added: MiniMount_Defaults.dwf = false
added: MiniMount_Defaults.scm = false
in lines 38 and 39
function MiniMount_CallMount(mount) lines 271-289
added a check for dismount while flying mode true/false
function MiniMount_Macro() lines 722-755
added a check for dismount while flying mode and single click mounting to create the appropriate macro syntax based on the current settings.
added 3 helper functions:
function settings_report() -- prints the current settings for MiniMount to the chat-box.
function dismount_while_flying_toggle() -- Turns Dismount While flying on and off.
function single_click_mounting_toggle() -- Turns Single Click Mounting on and off.
cleaned up unneeded remarks that I added earlier and removed the extra minimount settings so dwf and scm now only show up once on the /mm settings report.
added and spell-checked the following 4 lines to the localization.lua file:
MINIMOUNT_SCM_ENABLED = "Single click mounting has been enabled. Left-click macro to mount/dismount Right click to change next mount";
MINIMOUNT_SCM_DISABLED = "Single click mounting has been disabled. Left-click macro to mount or switch mounts; Right click to dismount; Middle click to change next mount";
MINIMOUNT_DWF_ENABLED = "Warning, Dismount While flying is now set to true this setting can be hazardous to your health";
MINIMOUNT_DWF_DISABLED = "Dismount while flying now set to false, you will not be allowed to dismount using the MiniMount macro while flying";
modified and spell-checked the readme file to reflect the changes.
going to attempt to re-upload the changed files now to with the cleaned versions of the files.
looks like I'm going to have to make a new ticket altogether to update the files. This may take a fiew minutes...