6 - New Fetures
What is the enhancement in mind? How should it look and feel?
I would like to see the ability to dismount while flying added
I would also like to see the ability to mount/dismount with the push of a single key added
Please provide any additional information below...
I have modified MiniMount so that on first install it works exactly like originally designed but when you use the command /mm dwf it allows you to dismount while flying. It also warns you that this may be dangerous. Also I added /mm scm, which allows you to use single click mounting or to use a single hot-key to mount and dismount. I also added /mm settings wich prints a settings report into chat initially to help me troubleshoot my changes, but left it in because I thaught it may be useful for other things in the future. I would like to submit the work I've done on it for your consideration for future releases but I've had trouble, untill now, figuring out how to submit it for some reason every time I try and log into curseforge.com using IE8 I get an error. I have only modified the main.lua and localization.lua files and will post them soon on here. Thank you very much for your consideration in this matter. Please reply either way so at lest I know you got the message and thank you for an awesome add-on...
the /mm settings report looks as follows on my main toon
MiniMount: Version: 1.7.1
MiniMount: DefaultMode: Auto
MiniMount: PreferFlight: 1
MiniMount: MountLists: table: 168566d8
MiniMount: dwf: true
MiniMount: scm: true
I needed this to figure out how to save my settings but I thought perhaps left in it could be useful in some way in future troubleshooting. I couldn't figure out how to make it show the use mount list setting or the default mount list settings so I remarked them out perhaps you can make that part work if needed.
How the MiniMount files were modified:
main.lua file
added: MiniMount_Defaults.dwf = false
added: MiniMount_Defaults.scm = false
in lines 39 and 40
added lines 234-239 to check for to add commands
/mm dwf
/mm scm
/mm settings
function MiniMount_CallMount(mount) lines 271-289
added a check for dismount while flying mode true/false
function MiniMount_Macro() lines 722-776
added a check for dismount while flying mode and single click mounting to create the appropriate macro syntax based on the current settings.
added 3 helper functions: lines 800-834
function settings_report() -- prints the current settings for MiniMount to the chat-box.
function dismount_while_flying_toggle() -- Turns Dismount While flying on and off.
function single_click_mounting_toggle() -- Turns Single Click Mounting on and off.
cleaned up unneeded remarks that I added earlier and removed other unneeded lines of scrip that i put in while modding it.
added and spell-checked the following 5 lines to the end of localization.lua file:
-- Dismount while flying and Single click mounting information
MINIMOUNT_SCM_ENABLED = "Single click mounting has been enabled. Left-click macro to mount/dismount Right click to change next mount";
MINIMOUNT_SCM_DISABLED = "Single click mounting has been disabled. Left-click macro to mount or switch mounts; Right click to dismount; Middle click to change next mount";
MINIMOUNT_DWF_ENABLED = "Warning, Dismount While flying is now set to true this setting can be hazardous to your health";
MINIMOUNT_DWF_DISABLED = "Dismount while flying now set to false, you will not be allowed to dismount using the MiniMount macro while flying";
modified and spell-checked the readme.txt file to reflect the changes.
This is a resubmission from a fiew minutes ago after I cleaned the unnecessary remarks out of the main.lua and spell-checked my changes to the localization.lua and readme.txt files for a clean submission. Will delete my earlier submission after I upload the new cleaned files to this submission.
Thank you for an awesome add-on and for your consideration of this matter!!!
| Name | Size | MD5 |
|---|---|---|
| main.lua | 25.0 KiB | d3fc0d6b1426feaca8c10e418d401621 |
| localization.lua | 3.4 KiB | 6613364390ce59d0789bab9f204e6931 |
| readme.txt | 7.0 KiB | edd83555ceedc0a0028be968a953d840 |
| User | When | Change |
|---|---|---|
| tberry7348 | Sat, 03 Oct 2009 11:26:57 | Added attachment readme.txt |
| tberry7348 | Sat, 03 Oct 2009 11:26:44 | Added attachment localization.lua |
| tberry7348 | Sat, 03 Oct 2009 11:26:25 | Added attachment main.lua |
| tberry7348 | Sat, 03 Oct 2009 11:26:05 | Create |
- 1 comment
- 1 comment
Facts
- Last updated on
- 03 Oct 2009
- Reported on
- 03 Oct 2009
- Status
- New - Issue has not had initial review yet.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
- #1
tberry7348 Sat, 03 Oct 2009 11:31:54I've tested the addon after cleaning up the remarks I added and fixing the spelling mistakes and so forth and it is working great with the changes I've made.