28 - Must reconfigure at each update. Intended?
Is it possible to modify the code or add an option to save basic configuration variables so we don't have to reconfigure Necrosis from scratch each time there's an update? I do appreciate the updates, but there are a lot of them and probably will continue to be a lot more in the future based on the current pace. Possible to save menu settings at least?
| User | When | Change |
|---|---|---|
| ArPharazon | Thu, 10 Dec 2009 04:47:13 | Changed status from Replied to Invalid |
| Lomig | Fri, 24 Oct 2008 05:59:33 | Changed status from Waiting to Replied |
| ArPharazon | Fri, 24 Oct 2008 05:42:01 | Changed status from New to Waiting |
| ctrost | Thu, 23 Oct 2008 14:03:47 | Create |
- 6 comments
- 6 comments
Facts
- Last updated on
- 10 Dec 2009
- Reported on
- 23 Oct 2008
- Status
- Invalid - This was not a valid report.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
- #6
technocoreai Sat, 13 Dec 2008 04:32:44I really don't get it. Why hardcode button indices (“button 3”)? Last time I looked at Lua, it supported hashes and according to pretty much every SavedVariables file you can save and restore them. Besides, even if you don't want to refactor Necrosis to support this, at least don't nuke the whole config. There's tons of stuff that doesn't use array indices — menu bar positions, shard bag settings, alert settings etc.
- #5
Lomig Mon, 27 Oct 2008 13:12:51Most addons have hard-coded buttons. Necrosis have dynamic buttons, created on demand. So to know which button you need to have, your saved-variable file contain a list of buttons that necrosis need, and necrosis have access to them via their number instead of their name (to avoid having a non functional affliction talent button for a destruction warlock)
Exemple: {Demonic Armor, Fel Armor, Detect Demon, Soullink, Banish}
In the next release, I'll remove the Detect Demon one (button 3 in this simplified example) because Blizzard has created since the beginning of Necrosis a nice interface option for this.
If I remove it without wiping your datas, then necrosis will consider having 5 buttons. if I explicitely use a function on the 5th button, you'll have a lua error. I am clever enough to do that. But when I ask for a loop "For every button in there do something...", Lua environment is not as clever as me : it will get the error message.
If I add a button instead of removing one, no lua error, Necrosis will work as usual. But the last button in the list won't be created, so won't be showned.
It is not obvious, but when I changed Necrosis for WoW 2.0, I added an unseen and undocumented function that is not yet in the setting menu to be able to show/hide/move buttons in their menus. This is also why I've got a button list in your savedvariables. I am currently working on a way to use it in a user-friendly way.
And eventually, I have a philosophy in programming : Release early, release often : I could wait the creation of all buttons, deletion of all buttons, and then release the addon... I would be as every other addons, with only a wipe of your datas every few monthes (or worst, a claim that is the addon has error, please remove manually your savedvariables files).
I do not work like that, because even if it is frustrating to have to reset Necrosis frequently, at least you have Necrosis back since three days after the patch.
This beeing said, I must confess there had been two wipes by mistakes : One from ArPharazon, and one from me. :)
- #4
technocoreai Sun, 26 Oct 2008 04:42:47Why exactly is that so? Necrosis is the only addon exhibiting this behavior, after all, all other addons seem to cope with updating just fine.
- #3
xtoq Sun, 26 Oct 2008 03:03:02I did read that this will stop (or decrease?) soon, when the constant updates stop, but I agree this would be a nice function to have.
- #2
Lomig Fri, 24 Oct 2008 05:59:32Config has to be reseted each time I chan ge something in config data. I'm trying to change this the less possible, but when I cannot do otherwise... I cannot do otherwise.
- #1
ArPharazon Fri, 24 Oct 2008 05:41:50I think this issue has been fixed because I updated to latest version today and it did not reset my config.