Necrosis LdC

49 - Misspelled Fly - Mount defination

What is the issue?

Please provide any additional information below.
=====================================================
Iam Play on German Server Ysera a Warlock LvL 70 and have a "Schneller lila Greif"

but Necrosis RC1 have him detect as "Schneller purpurfarbener Greif" (Think it is a old defination that are gone with the Patches). I have tagget in Mount Config "Use Own Mount"

German defination : purpurfarben (er) = lila

so are in German Language

Schneller purpurfarbener Greif = FALSE

Schneller lila Greif           = TRUE

Please fix it...

Best regards + many thanks for youre Work

Drachenstern / Ysera

User When Change
ArPharazon Thu, 01 Jan 2009 06:37:41 Changed status from New to Fixed
Drachenstern Fri, 31 Oct 2008 20:19:49 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of ArPharazon ArPharazon Thu, 01 Jan 2009 06:37:25

    It seems the GetCompanionInfo API will returns a different name for some mounts than GetSpellInfo API!

    I ran into this problem with my Bronze Drake from heroic stratholme - GetCompanionInfo returns it as "Bronze Drake Mount", when the correct name is just "Bronze Drake" :D

    I have implemented the workaround as suggested by Arture and its working very nicely, so it will be included in the next version (RC3).

  • Avatar of ArtureLeCoiffeur ArtureLeCoiffeur Sat, 08 Nov 2008 14:41:24

    I just ran into the same problem. There is an easy workaround - buy a red gryphon :-P

    Programmatically, this can be solved by retrieving the spell name. This change in Necrosis.Mount_InitLeft puts the correct spell name in the drop-down menu:

    		local _, _, spellMount = GetCompanionInfo("MOUNT", i)
    		nameMount = GetSpellInfo(spellMount)
    		Monture[i] = nameMount
    

    Alas, the spell is still called by the wrong name. I don't understand the code well enough to provide a complete patch. With the change above, the tooltip still uses the wrong name, and the spell does not work. So the mapping through GetSpellInfo() must be applied somewhere else, too.

    I have to leave now and won't be able to look at it until tomorrow. Maybe I will find time then to complete the patch.

    UPDATE:
    I changed every invocation of GetCompanioninfo() to retrieve the spell number and call GetSpellInfo. This makes it work. I.e. the drop down menus have "lila", the toolstip does, and the "lila Greif" is conjured.

    The code should probably use a wrapper function that emulates GetCompanionInfo but returns the name retrieved with GetSpellInfo.

  • Avatar of ArPharazon ArPharazon Sat, 01 Nov 2008 10:20:05

    We cannot fix this because the mount names are translated by Blizzard.

    For example, you have the Swift Purple Gryphon:
    -> http://www.wowhead.com/?spell=32292

    Necrosis uses the Blizzard code API to translate the name, like this:
    -> local name = GetSpellInfo(32292)

    result:
    - in English locale 'name' = "Swift Purple Gryphon"
    - in German locale 'name' = "Schneller purpurfarbener Greif"

    Sorry :/

  • 3 comments

Facts

Last updated on
01 Jan 2009
Reported on
31 Oct 2008
Status
Fixed - Developer made requested changes. QA should verify.
Type
Other - Some other kind of issue
Priority
Medium - Normal priority.

Reported by

Possible assignees