When a spell has SpellInfo(... combo=0), it indicates to Ovale that it is a finisher that consumes all of the combo points. However, Ovale takes that info and makes incorrect use of it when it computes the damage multiplier for that finisher. Right now, it takes the damage multiplier that's correctly computed, then multiplies it by the number of combo points consumed. However, that is only an approximation, and the finishers have much more complex formulas than simply scaling up the damage multiplier.
We should simply provide a way to allow the script to query how many combo points were consumed by the finisher. That would allow the script author to write the correct formulas for computing spell damage for comparison purposes.
|jlam||Sep 18, 2012 at 00:07 UTC||Changed status from Started to Fixed|
|jlam||Sep 17, 2012 at 20:14 UTC||Changed status from New to Started|
|jlam||Sep 17, 2012 at 20:14 UTC||Changed assigned to from Sidoine to jlam|
|jlam||Sep 17, 2012 at 20:12 UTC||
Added attachment 0001-Fix-for-ticket-161.patch
|jlam||Sep 17, 2012 at 01:41 UTC||Create|
- 4 comments