You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #4

  jlam Sep 17, 2012 at 21:54 UTC - 0 likes

  It's also possible with this patch to make full use of the Damage(id) and LastSpellEstimatedDamage(id) conditions. For example, you can add SpellInfo() for Rip that looks like:

  Define(dream_of_cenarius_damage 108381)
      SpellInfo(dream_of_cenarius_damage duration=30)
  Define(rip 1079)
      SpellInfo(rip duration=16 energy=30 tick=2 combo=0)
      SpellInfo(rip base=113 bonuscp=320 bonusapcp=0.3872) # damage coefficients
      SpellAddTargetDebuff(rip rip=1)
      SpellDamageBuff(rip dream_of_cenarius_damage=1.25)
  

  With the above information, you can use Damage(rip) as a script condition returning a number that's computed as:

  Damage(rip) == { 113 + (320 * CP) + (0.3872 * AP * CP) } * DamageMultiplier(rip)
  

  You can also use LastSpellEstimatedDamage(rip) to get the snapshotted damage estimate of the last Rip. Note that these estimates won't include the damage multipliers for mastery effects.

• 

  • Reply
  • #3

  jlam Sep 17, 2012 at 21:24 UTC - 0 likes

  Just commentary on this ticket:

  For finishers that consume all of their combo points, you should use combo=0 instead of combo=-5 in the SpellInfo() for that finisher. The only exception is Savage Roar if Glyph of Savagery is present. Usually, you can't do a finisher with 0 CPs and Ovale assumes that is always true. So, for Savage Roar, you can do:

  Define(savage_roar ...)
      SpellInfo(savage_roar combo=0)
      SpellInfo(savage_roar combo=-5 glyph=glyph_of_savagery)
  Define(glyph_of_savagery ...)
  

  The second SpellInfo() will overwrite any matching parameters that were set in the first SpellInfo().

• 

  • Reply
  • #2

  jlam Sep 17, 2012 at 20:12 UTC - 0 likes

  I've attached a patch that fixes this issue. In addition to provding a way to get the number of combo points used, it also provides a way to get the estimated damage of a spell for comparison purposes.

• 

  • Reply
  • #1

  jlam Sep 17, 2012 at 01:50 UTC - 0 likes

  I will add the conditions for querying the number of combo points consumed. For now, if you need correct values for the damage multiplier, avoid using combo=0.