Ovale Spell Priority

215 - Memory leak?

What version of Ovale are you using?
5.2.9

What class and specialization were you playing when the problem occurred?
Monk, Brewmaster

Which script were you using when the problem occurred?  If possible, please provide the smallest script that demonstrates the problem.
Stock script.

What steps will reproduce the problem?
Sit still and watch memory counter.

Do you have an error log of what happened?
No Error.

Please provide any additional information below.
Memory usage just keeps going up about .8mb a second. Causes my ui to freeze every so often especially when it's taking up +30mb
Here is a list of my addons:
!BugGrabber
_NPCScan
_NPCScan.Overlay
AdvancedIconSelector
AdvancedIconSelector-KeywordData
Ara_Broker_Guild_Friends
BugSack
CoolLine
DBM-Core
DBM-Party-BC
DBM-Party-Cataclysm
DBM-Party-MoP
DBM-Party-WotLK
DBM-ThroneofThunder
ElvUI
ElvUI_Config
MikScrollingBattleText
MSBTOptions
Nerien_Ovale_Scripts
Ovale
shPerformance
Skada
SpeedyLoad
StaggerMeter
TidyPlates
TidyPlates_Graphite
TidyPlates_Grey
TidyPlates_Neon
TidyPlates_Quatre
TidyPlatesHub
TidyPlatesWidgets
VuhDo
VuhDoOptions
WIM
WIM_Elvui
WoWDBProfiler
-----------------------------------------
I'm going through all the addons 1 by 1 now and see if it's another addon causing this to Ovale.

User When Change
jlam Mar 31, 2013 at 18:56 UTC
jlam Mar 31, 2013 at 10:18 UTC
jlam Mar 31, 2013 at 10:12 UTC
jlam Mar 28, 2013 at 04:39 UTC
jlam Mar 27, 2013 at 20:23 UTC
jlam Mar 27, 2013 at 20:22 UTC
jlam Mar 16, 2013 at 09:21 UTC
jlam Mar 13, 2013 at 18:39 UTC Changed assigned to from Sidoine to jlam
jlam Mar 13, 2013 at 18:39 UTC
L2Leona Mar 12, 2013 at 23:35 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 10 comments
  • Avatar of jlam jlam Mar 31, 2013 at 18:56 UTC - 0 likes

    This is fixed in 5.2.27.

  • Avatar of jlam jlam Mar 31, 2013 at 10:12 UTC - 0 likes

    I've finally found a starting point for investigations. With an empty script, Ovale's memory usage doesn't grow. However, with the next simplest script that has a single icon that does nothing, e.g.:

    AddIcon { }
    

    then Ovale will start growing in memory usage slowly. This points to one of OvaleFrame, OvaleIcone, or OvaleBestAction.

  • Avatar of jlam jlam Mar 28, 2013 at 04:39 UTC - 0 likes

    I've made some changes that I've released in Ovale 5.2.20 that reduce the rate at which the memory is being consumed before it is released. Please try and see if your observations match mine.

  • Avatar of jlam jlam Mar 27, 2013 at 20:22 UTC - 0 likes

    The current status of this ticket is that it is still under investigation. I have been reading the code extensively and been doing experiments to determine the cause of the yo-yo memory usage, but I haven't been able to pinpoint it yet. I will update as I learn more.

  • Avatar of jlam jlam Mar 16, 2013 at 09:21 UTC - 0 likes

    I have improved the memory efficiency of two of what I thought were the likelier culprits for the ballooning memory usage. Right now, Ovale appears to be consuming about 150kB/s on my machine while my toon is standing in the Shrine of the Seven Stars. It actually starts out at around 4MB then slowly grows to around 25MB, then quickly drops back down to 4MB before continuing the cycle.

    Could you test Ovale 5.2.13beta2 (and Nerien's Ovale Scripts 5.2.5beta if you are using that together with this addon) and report back on whether the memory usage is improved on your machine or not? I'm still trying to collect more data to figure out where the memory is being slowly allocated.

  • Avatar of jlam jlam Mar 14, 2013 at 05:44 UTC - 0 likes

    Right now, I just have to go through the code and audit the memory usage to make sure we don't cause a lot of memory churn unintentionally. The recent code changes to improve encapsulation of the different parts of the code are part of this work. It just takes time, but hopefully not too much more.

    The change that caused memory usage to noticeably increase was recent, and it was unfortunately something that had to happen to correct a more severe problem.

  • Avatar of L2Leona L2Leona Mar 14, 2013 at 04:45 UTC - 0 likes

    @jlam: Go

    Ah nice explination, so is there anything on my end that I can do to dampen the effects? I noticed when I enabled all my addons and watch for the garbage collector script to run and I noticed it would drop my frames by 70% for 1 second while it cleaned up everything. I swear this wasn't an issue before 5.2.

    I've been using ovale for almost 5 years, never had that issue. Well anyways reguardless of the outcome, Ovale is an awesome addon, keep up the great work.

  • Avatar of jlam jlam Mar 13, 2013 at 22:22 UTC - 2 likes

    No, those issues aren't related. I'm investigating some ways to reduce the high-water memory usage of Ovale. The high memory usage is a bit of a phantom because the Ovale releases the memory; it's just not yet reclaimed by the client's garbage collector. However, Ovale can certainly be more efficient in not creating and destroying many Lua tables per second, which is what creates the artificially high memory usage charged to Ovale.

  • Avatar of Anteract Anteract Mar 13, 2013 at 19:04 UTC - 0 likes

    Just wanted to add a "me too"

    And my shadow priest doesn't like the default script either. (see other ticket) Wonder if they are connected?

    Tested this on my Shammy though, it still has the growing memory issue

  • Avatar of L2Leona L2Leona Mar 12, 2013 at 23:48 UTC - 0 likes

    So I went through all the addons until it was just the blizzard UI and it still has this problem. I noticed this issue since 5.2. If there's anything I can provide that can help, let me know n_n

  • 10 comments

Facts

Last updated
Mar 31, 2013
Reported
Mar 12, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees