PetTracker

272 - Dropdown Taint

What steps will reproduce the problem?
1. Seems to just happen through normal play
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? 5.4.1

Do you have an error log of what happened?

6x [ADDON_ACTION_BLOCKED] AddOn "PetTracker" tried to call the protected function "CompactRaidFrame7:Show()".
!BugGrabber-r194\BugGrabber.lua:587 in function <!BugGrabber\BugGrabber.lua:587
<in C code>
FrameXML\CompactUnitFrame.lua:285 in function "CompactUnitFrame_UpdateVisible"
FrameXML\CompactUnitFrame.lua:243 in function "CompactUnitFrame_UpdateAll"
FrameXML\CompactUnitFrame.lua:98 in function <FrameXML\CompactUnitFrame.lua:45

Locals:
nil

Please provide any additional information below.

There are quite a few, this is just one of them

User When Change
Jaliborc Dec 22, 2013 at 22:50 UTC Changed status from Accepted to Fixed
Jaliborc Oct 20, 2013 at 11:14 UTC Changed name from Protected function call conflict with CompactRaidFrame to Dropdown Taint
Jaliborc Oct 20, 2013 at 11:14 UTC Changed status from New to Accepted
Ralin Oct 09, 2013 at 08:47 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of Ralin Ralin Oct 10, 2013 at 00:10 UTC - 0 likes

    @ckaotik: Go

    Awesome, thank you!

  • Avatar of ckaotik ckaotik Oct 09, 2013 at 22:38 UTC - 1 like

    You can still use this command to toggle stables (or species, if you write 'Species' instead of 'Stables' ;) )

    /run PetTracker.WorldMap:Toggle('Stables')
    

    The original snippet adds those two functions as checkable buttons to the world map dropdown where you can already choose whether to display dig sites, quest locations or tamers :)

  • Avatar of Ralin Ralin Oct 09, 2013 at 21:47 UTC - 0 likes

    @ckaotik: Go

    Haven't had a chance to apply your fix yet, but greatly appreciated. Unsure if Jaliborc regularly updates (though leaning towards no, since he's yet to fix Bagnon).

    My level of coding knowledge hovers in the negatives so i'll have to inquire as to what you mean by "convenient toggling". Looking at it, I assume the fix will prevent toggling the display of battle pet tracking and stables tracking but since you said convenient, i'm curious if there's an inconvenient form of toggling it allows. :D

  • Avatar of ckaotik ckaotik Oct 09, 2013 at 20:15 UTC - 1 like

    I have the same issue. At first it seemed like the WatchFrame or general tracking was the reason, but those work fine. Then I followed it back to the WorldMap hook to add dropdown options. DIsabling the hook solves the issue for me :) At the same time, this "fix" removes convenient toggling two useful options, so make sure to set them up beforehand.

    -- Features/WorldMap.lua
    hooksecurefunc('WorldMapShowDropDown_Initialize', function()
    	if true then return end -- quick and very, very dirty
    	UIDropDownMenu_AddButton {
    		text = L.ShowPets,
    		func = function() self:Toggle('Species') end,
    		checked = self:Active('Species'),
    		keepShownOnClick = true,
    		isNotRadio = true
    	}
    
    	UIDropDownMenu_AddButton {
    		text = L.ShowStables,
    		func = function() self:Toggle('Stables') end,
    		checked = self:Active('Stables'),
    		keepShownOnClick = true,
    		isNotRadio = true
    	}
    end)
    

    Edit: taint.log said it's because the addon is tainting UIDROPDOWNMENU_MENU_LEVEL. Your general-purpose taint "reason" :/

    Last edited Oct 09, 2013 by ckaotik
  • 4 comments

Facts

Last updated
Dec 22, 2013
Reported
Oct 09, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees