ReadySetDing

2 - Guild Announce/Report Setting

The problem is as simple as this:
On the RSD advanced tab, the guild announce/report does not save between sessions or after reloading the UI. All other settings save properly.

11/27/2010 Edit: The Announce/Show checkbox state saves if "Show Guild" is selected, but not if "Announce to Guild" is selected (when the checkmark is gray).

User When Change
Ketho Dec 20, 2010 at 01:12 UTC Changed status from Started to Fixed
Eincrou Nov 28, 2010 at 00:33 UTC Changed description:
  The problem is as simple as this:
  On the RSD advanced tab, the guild announce/report does not save between sessions or after reloading the UI.  All other settings save properly.
+
+ [b]11/27/2010 Edit[/b]: The Announce/Show checkbox state saves if "Show Guild" is selected, but not if "Announce to Guild" is selected (when the checkmark is gray).
Ketho Nov 27, 2010 at 19:07 UTC Changed status from Verified to Started
Ketho Nov 27, 2010 at 19:07 UTC Changed status from Accepted to Verified
Ketho Nov 27, 2010 at 16:28 UTC Changed status from New to Accepted
Eincrou Nov 25, 2010 at 10:05 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of Ketho Ketho Feb 07, 2011 at 20:00 UTC - 0 likes
  • Avatar of Eincrou Eincrou Dec 26, 2010 at 00:48 UTC - 0 likes

    I've been trying to learn how to code with Lua over the past few weeks, and I used my limited knowledge to, using the info in your first response, find line 823 in Core.lua:

    GuildLevelup = false,
    

    I set this to nil instead of false and it saves me from manually turning announce on every time I log in/reload.

    Looking at your code overwhelms me. I understand very little of it. I have a lot to learn before I can make any useful addons. I took an introductory Java class 6 years ago, but I've since forgotten almost all of it. I'm basically starting from square one with programming.

    Even so, I enjoyed programming before and I'm up to the challenge. Do you have any advice for how I should go about doing this? I'm going through an ebook on Lua to learn the basics of working with the language. What was your experience with programming, and Lua specifically, when you started making addons?

    As always, I thank you for your work on RSD. So far I have used it while leveling seven different characters, and will use it for many more!

  • Avatar of Ketho Ketho Dec 20, 2010 at 01:10 UTC - 0 likes

    Actually a little update on this part, while I am still rewriting this addon for better readability/performance

    There is a defaults table e.g.

    defaults = {
       guildAnnounce == false,
    }
    

    So while when the setting was set to nil, it would fall back to the defaults,
    Which is false

    For better coding, there is actually no need to set a defaults option to false/nil, so I left it out, which also fixed this bug

    Im kinda confusing every1 who is reading this
    # TLDR: its fixed for the coming v0.77, hurray! (after like a month)

    Last edited Dec 20, 2010 by Ketho
  • Avatar of Ketho Ketho Nov 28, 2010 at 09:36 UTC - 0 likes

    My boolean logic on tristate nil (greyed) checkboxes is flawed ><

    • true -> true
    • false -> false
    • nil -> false

    I'm not sure whats the "conventional" way, but will try to use another variable to save that nil

    • nil -> if anotherVar == true then nil else
      • true -> true
      • false -> false
    Last edited Nov 28, 2010 by Ketho
  • 4 comments

Facts

Last updated
Dec 20, 2010
Reported
Nov 25, 2010
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees