ReadySetDing

8 - Minor Problems

Ketho,

1) I discovered that ReadySetDing is looking for the Ace3 libs in an above directory, even tho you have a Ace3 lib directory under ReadySetDing. I tested this and as soon as the Ace3 addon lib is installed under ..\Interface\AddOns  - the problem is corrected. That's a matter if directing where you pointing to for the libs, or you may just want to require that the Ace3 be previously installed.

2) In the Auto Gratz section under ReadySetDing, [NAME] uses the lowercase version of the players name, not the normal version used on the Top Level section of the ReadySetDing or the Guild Dings section. Also, you have 2 place-holder variables {rt1} and {rt3} - I assume rt = raid targets and the 1 and 3 refer to the indexing of them where rt1 = star, and rt3 = diamond. Since there is no pop-up window, in the same manner as the Top LeveL and Guild Dings section, there is no way to know what variables you can use. Suggestion would be to standardize the pop-up windows on all three of these sections, use the same code, same window, etc for all three. Also, include full info on target icons in the pop-up window.

That's all, so far.

Mark

User When Change
Ketho Feb 22, 2011 at 01:43 UTC Changed status from Started to Fixed
Ketho Feb 19, 2011 at 21:23 UTC Changed status from Replied to Started
MarkParish Feb 19, 2011 at 14:43 UTC Changed status from Waiting to Replied
Ketho Feb 19, 2011 at 11:01 UTC Changed status from Accepted to Waiting
Ketho Feb 18, 2011 at 11:06 UTC Changed status from New to Accepted
MarkParish Feb 17, 2011 at 23:12 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of Ketho Ketho Feb 19, 2011 at 22:28 UTC - 0 likes

    .. I agree, thanks for the feedback again, Mark

    although in the end, another error ended up getting fixed they pointed out in that thread I posted ..

  • Avatar of MarkParish MarkParish Feb 19, 2011 at 20:41 UTC - 0 likes

    ok then I think we can close out the ticket after correcting that error #51

  • Avatar of Ketho Ketho Feb 19, 2011 at 17:17 UTC - 0 likes

    As far as I can see, error #51 is the only error concerning v0.80 and this is the concerning code:

    local function GetClassColor(class)
    	return format("%02X%02X%02X", RAID_CLASS_COLORS[class]["r"]*255, RAID_CLASS_COLORS[class]["g"]*255, RAID_CLASS_COLORS[class]["b"]*255)
    end
    


    function RSD:GUILD_ROSTER_UPDATE()
    	for i = 1, GetNumGuildMembers() do
    		local name, rank, _, level, class, zone, _, _, _, _, classFileName = GetGuildRosterInfo(i)
    		local classColor = GetClassColor(classFileName)
    		if name then
    


    As far as I can see, it's receiving a nil. It's trying to get the unit's class before the sanity check, that I added since your last bug report, I might as well fix that ...

    But that's an entirely unrelated/different bug!
    I seriously can't see any error that got anything to do with the Ace3 libs ..

    Although there is error #2 about some AceConfigDialog stuff, but RSD is not enabled/included, or mentioned at all in that error ...

    and all the other errors are other stuff, and 2 errors are from the v0.79 beta version, which was broken (><)

    And most likely any errors with pointing to files/libraries from the .TOC, would be logged to ...\Logs\FrameXML.log ...

    Sorry man, I really can't see anything actually wrong concerning the Ace3 libs embeding

    Related ticket: #9
    Last edited Feb 19, 2011 by Ketho
  • Avatar of MarkParish MarkParish Feb 19, 2011 at 14:43 UTC - 0 likes

    Ok, here you go.

    Name Size MD5
    _Swatter.lua 131.1 KiB 55a054de9de3...
  • Avatar of Ketho Ketho Feb 19, 2011 at 11:00 UTC - 0 likes

    uhmm I'm now requesting an actual error log,
    and if there is an actual \ReadySetDing\Libs\ folder in your version of this addon

    I posted a thread about this, and nothing yet shows the embeding to be wrong ..

    Last edited Feb 19, 2011 by Ketho
  • Avatar of MarkParish MarkParish Feb 19, 2011 at 00:31 UTC - 0 likes
    Quote:

    Ehmm I'm not sure what you mean? Because RSD should work fine without the Ace3 standalone, as I just tested that setup, (which included the \ReadySetDing\Libs) ..

    Do you mean I should mention somewhere that RSD requires the Ace3 standalone to be "installed" too? Because then I'd use RequiredDeps to make sure it'll use, and mentions that it should be loaded with the Ace3 standalone

    I'm not sure why this would be occuring, but you're right that the code should be point to your libs below RSD.

    1. The error was not occuring before I re-installed RSD
    2. The error occured after I installed RSD.
    3. The error disappeared after I installed Ace3 at root level.

    Thus either,

    1. The libs under RSD are out of sync with the latest version of Ace3
    2. The code was not pointing to the right location
    3. Something else was occuring ...

    Because it seems that option 3. is more likely ... therefore, I was just suggestion that the mention that users needed the standalone version of Ace3 installed seemed the best course of action. Hope that helps.

    Mark

    Last edited Feb 19, 2011 by MarkParish
  • Avatar of Ketho Ketho Feb 18, 2011 at 11:22 UTC - 0 likes
    Quote:

    Ok, that was the error, but as soon as I installed Ace3 ... it went away [...] Six one way - Half-dozen the other ... I'd suggest not spending a lot of time on it unless the answer for it just pops right up at you.

    Ok, channeling my inner Bruce Lee ... aka be like water ... write "Ace3 must be installed in AddOn directory, for ReadySetDing to function."

    Ehmm I'm not sure what you mean? Because RSD should work fine without the Ace3 standalone, as I just tested that setup, (which included the \ReadySetDing\Libs) ..

    Do you mean I should mention somewhere that RSD requires the Ace3 standalone to be "installed" too? Because then I'd use RequiredDeps to make sure it'll use, and mentions that it should be loaded with the Ace3 standalone

    ## RequiredDeps: Ace3
    

    But as I said, it should already work as it is ...


    Side note, I should have mentioned earlier:
    Currently, there are these tags in the .toc file:

    ## OptionalDeps: Ace3
    ## X-Embeds: Ace3
    

    I'll do a quick quote from this old Ace3 tutorial:

    Quote:

    The OptionalDeps part is there in case a user of your addon comes along later and chooses to use a standalone Ace3 instead of using the embedded libraries in your Libs folder and the X-Embeds is there to tell updaters what libs it needs to download separately if the user don't want to use the embedded libs


    tbh, now I'm quite confused, because this is the first time since I'm looking into the .TOC tags.

    I just copypasted the tags from the tutorial and never looked back, and never used repositories
    v0.80 [2011.02.18]

  • Avatar of Ketho Ketho Feb 18, 2011 at 11:05 UTC - 0 likes

    There was a link below the Markup Type thingie:
    http://kb.curseforge.com/markup-types/

    Quote:

    To that end, when ReadySetDing response with a player's name in lower case, it seems like an AddOn is responding ... when ReadySetDing response with the name with the first lettered capitalized it seems more "human" because - for example - if I were to respond to you I wouldn't type "ketho" I'd type "Ketho"... and if I was typing in the response in guild chat to a Ding I'd type "Congrats" and the do Shift+Left-Click on the players name which would place the players name (with the 1st letter capitalized) on the line for the response.

    Lol, I myself never Shift+Left-Clicked a player's name, because I was simply too lazy and just typed "gz" instead. You convinced me with your history lesson, I'll change it back :)

    Last edited Feb 18, 2011 by Ketho
  • Avatar of MarkParish MarkParish Feb 18, 2011 at 07:10 UTC - 0 likes

    (How do you do qoutes??) "Replacing [NAME] with lowercase "name" was done intentionally, because I thought that would make it look more "real", instead of by an Autogratz addon." - Ketho

    My answer to this is in "Computing machinery and intelligence" (Mind, October 1950), Alan Turing addressed the problem of artificial intelligence, and proposed an experiment which became known as the Turing test, an attempt to define a standard for a machine - or in this case, code - to be called "intelligent". The idea was that a computer - with the code - could be said to "think" if a human interrogator could not tell it apart, through conversation, from a human being.

    The 1st "program" to said to "pass" the Turing test was ELIZA which worked by examining a user's typed comments for keywords. If a keyword is found, a rule that transforms the user's comments is applied, and the resulting sentence is returned. If a keyword is not found, ELIZA responds either with a generic riposte or by repeating one of the earlier comments.

    Now ELIZA - like ReadySetDing - wasn't really an AI, but it could fool humans into "thinking" that the responses came from a "human" vs a "machine".

    To that end, when ReadySetDing response with a player's name in lower case, it seems like an AddOn is responding ... when ReadySetDing response with the name with the first lettered capitalized it seems more "human" because - for example - if I were to respond to you I wouldn't type "ketho" I'd type "Ketho"... and if I was typing in the response in guild chat to a Ding I'd type "Congrats" and the do Shift+Left-Click on the players name which would place the players name (with the 1st letter capitalized) on the line for the response.

    Mark

  • Avatar of MarkParish MarkParish Feb 18, 2011 at 05:59 UTC - 0 likes

    Ok, that was the error, but as soon as I installed Ace3 ... it went away

    ["timestamp"] = "2011-02-17 19:45:00",
    ["context"] = "Global",
    ["stack"] = "(tail call): ?\nInterface\\AddOns\\ReadySetDing\\ReadySetDing.lua:1270 in function <Interface\\AddOns\\ReadySetDing\\ReadySetDing.lua:1269\nInterface\\AddOns\\ReadySetDing\\ReadySetDing.lua:1710 in function `?'\n...Ons\\Ace3\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:147 in function <...Ons\\Ace3\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:147\n[string \"safecall Dispatcher[1]\"]:4: in function <[string \"safecall Dispatcher[1]\"]:4>\n[C]: ?\n[string \"safecall Dispatcher[1]\"]:13: in function `?'\n...Ons\\Ace3\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:92 in function `Fire'\nInterface\\AddOns\\Ace3\\AceEvent-3.0\\AceEvent-3.0.lua:120 in function <Interface\\AddOns\\Ace3\\AceEvent-3.0\\AceEvent-3.0.lua:119\n",

    Six one way - Half-dozen the other ... I'd suggest not spending a lot of time on it unless the answer for it just pops right up at you.

    Ok, channeling my inner Bruce Lee ... aka be like water ... write "Ace3 must be installed in AddOn directory, for ReadySetDing to function."

    Mark

    Last edited Feb 18, 2011 by MarkParish

Facts

Last updated
Feb 22, 2011
Reported
Feb 17, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees