Recap

3 - 4.2 issues

Seems like 4.64 (toc incorrectly lists it as 4.63 still) hasn't been updated to handle the two new flags fields in the unfiltered combat log Searched for sourceFlags and changed line 5291 to:
<font color="#C0C0C0">local timestamp, eventType, hideCaster, sourceGUID, sourceName, sourceFlags, <font color="red">sourceMoreFlags</font>, destGUID, destName, destFlags, destMoreFlags = ... </font>
lines 2364-2371 to:
<font color="#C0C0C0">	local timestamp, eventtype, hideCaster, sourceGUID, sourceName, sourceFlags, <font color="red">sourceMoreFlags</font>, destGUID, destName, destFlags, <font color="red">destMoreFlags</font>, x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11, x12, x13, x14, x15, x16
	if ... then
		-- we got an argument
		timestamp, eventtype, hideCaster, sourceGUID, sourceName, sourceFlags, <font color="red">sourceMoreFlags</font>, destGUID, destName, destFlags, <font color="red">destMoreFlags</font>, x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11, x12, x13, x14, x15, x16 = ...
	else
		-- no argument, stuff should be in ArgumentListForErrorReporting
		timestamp, eventtype, hideCaster, sourceGUID, sourceName, sourceFlags, <font color="red">sourceMoreFlags</font>, destGUID, destName, destFlags, <font color="red">destMoreFlags</font>, x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11, x12, x13, x14, x15, x16 = unpack(ArgumentListForErrorReporting)
	end </font>
line 5617 to:
<font color="#C0C0C0">eventDispatchFunction(timestamp, eventType, sourceOwnerNameGUID, sourceFlags, specialMelee, destOwnerNameGUID, destNameGUID, destFlags, select(<font color="red">12</font>, ...)) </font>
line 5441 to:
<font color="#C0C0C0">	local amount, overheal = select(<font color="red">15</font>, ...) </font>
User When Change
Hawksy Jul 07, 2011 at 17:41 UTC
Hawksy Jul 05, 2011 at 02:59 UTC
Kitjan Jun 29, 2011 at 03:16 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of Hawksy Hawksy Jul 04, 2011 at 22:03 UTC - 0 likes

    A beta version, NOT tested on WoW, has been uploaded. Let me know if it lets Recap work with patch 4.2.

    Hawksy

  • Avatar of Hawksy Hawksy Jun 30, 2011 at 17:00 UTC - 0 likes

    There will need to be changes to 12 lines in RecapCombat to adjust for the two new parameters.

    Hawksy

  • 2 comments

Facts

Last updated
Mar 30, 2012
Reported
Jun 29, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees

  • Avatar of Hawksy
    • Manager
    • Author
    • Maintainer
    • Ticket Manager
    • Documenter
    • Artist
    • Contributor