Reforgenator

23 - Not Less Than

What is the enhancement in mind? How should it look and feel?

I would like an option to not go less then a number I enter.  So if I want the Hit rating to never be less then 600, or haste never less then 512, I just enter that in somewhere and when it's calculates the values it will be close maybe slightly above, but never below what I specify.

Please provide any additional information below.

I have a screen shot of one option you have in your program but I'd like a different one to wrok as I sedcribed.

User When Change
ducky12432 Jan 23, 2012 at 06:05 UTC Changed status from Waiting to Fixed
gunboat Jan 12, 2011 at 05:43 UTC Changed status from Started to Waiting
gunboat Jan 08, 2011 at 00:02 UTC Changed status from Accepted to Started
gunboat Jan 03, 2011 at 14:24 UTC Changed status from New to Accepted
DanoPDX Dec 26, 2010 at 07:00 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of ducky12432 ducky12432 Jan 23, 2012 at 06:05 UTC - 0 likes

    Old out of date tickets that have been dealt with but never followed up on.

  • Avatar of DanoPDX DanoPDX Jan 10, 2011 at 23:33 UTC - 0 likes

    Ok let me do that and get back to you because I checked that box and it didn't go over.

    In the screen shot I am on my Lock, but the setting for my PVP frost spec are shown.

    Last edited Jan 10, 2011 by DanoPDX
    • WoWScrnShot_011011_155750.jpg
  • Avatar of gunboat gunboat Jan 09, 2011 at 23:32 UTC - 0 likes

    It just compares the amount under the cap to the smallest amount over the cap and takes whichever is closer to the cap. If you check the "must be over" checkbox, it always takes the smallest amount over the cap even if it isn't the closest. At worst, it only reforges one more item than it would without the "must be over" setting.

    So in your example, the 505 is the under. It would see which of the remaining items would reforge for the least amount greater than 5, and would take the one that was closer. Assuming it wound up choosing the same item as you and that item gave 26 more rating, it would have said abs(510-505) < abs(510-531) so would stay just under the cap. If you check the box for "must be over", it would have taken the "over" choice and ended up at 531.

    You can check the box and do a verbose reforging and it should print out the ratings you'd end up with so you can decide if that's what you want before actually doing the reforging.

  • Avatar of DanoPDX DanoPDX Jan 09, 2011 at 22:52 UTC - 0 likes

    For my PVP Entry it fell 5 points short in expertise.  I reforged another item manualy.  I needed 510 exp, and it was at 505.  After my manual reforge I was at 531.  What is the threshhold for not being less then a certain number?  Over is ok just as long as it's the least amount over that number.  < 5 no, > 21 OK (if the least amount over)

  • Avatar of DanoPDX DanoPDX Jan 09, 2011 at 20:07 UTC - 0 likes

    Here is my first try with the new 1.3.1

    I needed 24 exp rating (need 23 exp, at 666 needed 690), and I was already at hit cap 602 (needed 600 because of DW, for yellow attacks)

    My model contained:

    Stat Weights:

    hit 122
    exp 96
    mast 82
    crit 58
    haste 48

    Rules:
    #1: Hit 600
    #2: exp 690
    #3: Mastery max possible
    #4: Haste 254
    #5: crit 1530

    My expectation was that hit and exp would cap.  Mastery would be as high as it could however I expected aprox 1074 mastery rating.  Haste as indicated, and it would 'raise' my crit rating from 1389 to 1530.

    Outcome:

    Exp is perfect but the mastery rule made it such that reforginator would not raise the crit so I changed the order of the rules to:

    Rules:
    #1: Hit 600
    #2: exp 690
    #3: Haste 254
    #4: crit 1530
    #5: Mastery max possible

    New outcome:

    It wanted to reforge only two items out of all my gear, none of which were reforged.  Exp was perfect, crit was perfect and it left me with as much mastery as possible with my gear.  

    Reforginator made better choices than I would have on exp and crit to leave me with the highest values.  I appreciate all your explanations of how things work with your mod.  I feel that if I was willing to sacrafice 1 point in mastery for crit that it would do so perfectly rather then my hunting and pecking through my gear.

    Last edited Jan 09, 2011 by DanoPDX
  • Avatar of gunboat gunboat Jan 09, 2011 at 14:30 UTC - 0 likes

    Yes, 1.3.1-beta-2 has the checkbox for "must be over". And it will apply to any of the rules you check it for including "fixed"; if that's the rule you need to express your theory of stat optimization then go for it.

  • Avatar of DanoPDX DanoPDX Jan 08, 2011 at 23:03 UTC - 0 likes

    Did this make it into 1.3.1 B8? If so should I use fixed value and then it should not drop below that value?

    • WoWScrnShot_010811_150257.jpg
  • Avatar of DanoPDX DanoPDX Jan 05, 2011 at 10:55 UTC - 0 likes

    Today after running some heroics, I got gear that put me at 8.01% hit and 25 exp without geming for it, so I could go all str gems finally.  I restored all my items and opened up reforginator.  It would have reforged all my haste, hit, exp all to mastery.  I think since it saw I was at cap on hit and exp then it was free to reforge it away, not seeing that after reforging I would be under cap.

    "Only you can decide if that's a good trade to make, but I do think it's important the addon support you in making that decision." - gunboat

    I'll agree with that, however, mainly I am looking for it to maximise something that I might miss.  So for this request it's so that I stay at hit cap and exp cap and a certain amount of haste (my pref only) and all the rest goes to Mastery.  The added stat weights will help as well.

    Last edited Jan 05, 2011 by DanoPDX
  • Avatar of gunboat gunboat Jan 05, 2011 at 07:48 UTC - 0 likes

    It's all very finely-grained minmaxing. If you're 20 rating under the 17% spell hit cap, your miss rate on raid bosses is 0.167% or 1 out of 599 casts; your dps will suffer more variation from the RNG on the damage output than on missed spells. If you say "any amount under is bad", then we'd have to reforge another item to get over, and whatever you wind up reforging is wasting anything over 20 points and isn't being reforged to something else like haste. So if you wind up reforging 73 points into hit, then you gave up 73 points that you could have put into haste but effectively only got 20 points worth of hit for it.

    Only you can decide if that's a good trade to make, but I do think it's important the addon support you in making that decision.

  • Avatar of neoark1 neoark1 Jan 04, 2011 at 17:19 UTC - 0 likes

    Good idea for haste. Hit needs to be fixed little hit over the cap is good up under is bad.

Facts

Last updated
Mar 30, 2012
Reported
Dec 26, 2010
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees