You must login to post a comment. Don't have an account? Register to get one!

• 

  • #20

  tylerdurden2 Tue, 10 Nov 2009 09:58:33

  Some early thoughts.

  • Itemlinks are sometimes making me go crazy. For example yesterday I was using them and the dual wielding thing. Two non enchanted one hands. Turns out that their itemlink was different, because of the field uniqueId, part of the itemString

  item:itemId:enchantId:jewelId1:jewelId2:jewelId3:jewelId4:suffixId:uniqueId:linkLevel
  

  I hope that this won't cause more issues. what I would need most though would be to always use a substring of that, or to always first replace from suffixId till the end of the string with 0...

  • I like your idea, but maybe I could tweak it a bit. This is what I was thinking.

  in the cachedItems store something like "itemDps|itemHit" instead of the whole text to add to the tooltip

  onToolTipSetItem doesn't do the cache thingy, it simply always calls the function getItemSlotValue

  getItemSlotValue on the other hand does something like this:

  local item, link = passedTooltip:GetItem()
  if cachedItems[link] == nil then
         -- do the current code to compute the item value and hit value
         -- once they have been computed, store them
        cachedItems[link] = "itemDps|itemHit"
        return itemDps, itemHit
  else
        -- it isnt nil, therefore a cached value for the passed item exists
        -- using string.split for readability, will replace it with a select
        return cachedItems[link].split("|")
  end
  

  I can imagine that this will greatly speed up the gear optimizing function.

• 

  • #19

  Barfolomeu Mon, 09 Nov 2009 20:31:00

  Quote:

  Can you elaborate on this a bit? How do I cache it exactly? I need a way that, if for example I change a gem of choise in the rhadatip gem tab, will not use the cached value but recompute it. Same if I gem the item and so on so forth.

  I didn't look too far into your code but I imagine something like this:

  This is regarding hovers on items in your bags or character sheet. The Blizzard UI updates these tooltips on every update event to account for cooldowns. My suggestion was that you would cache the text that you would be applying to the tooltip, since this should never change once the tooltip is up. I would think something like this would be in order:

  • Store the link of the item for the tooltip at first event. The first event is when you first hover over the item in your character sheet or bag.
    
  • Compute the text that you're adding to the tooltip at first event. Cache it in a global table and do what would normally be done to the tooltip.
    
  • On the next event, check if the tooltip is for the same item as before (the mouse continues to hover over the item), simply display this cached value instead of computing it again...and again, etc.

  NOTE! The code has changed since the original post to account for the use of link as a unique identifier instead of item

  Some sample code:
  

  -- Globally declare lastLink: local lastLink = ""
  -- Globally declare a table to hold the cached items: local cachedItems = {}
  -- Then in your onToolTipSetItem handler, do this:
  -- It's likely the next two variables are already sent to the handler. I add this code here for the sake of completeness
  local item, link = GameTooltip:GetItem()
  -- We use the link here because link is unique. Say you dual wield the same weapons, but they're gemmed and enchanted differently
  if lastLink ~= link then
    -- If the text is not already cached...
    if cachedItems[link] == nil then
      -- populate cachedItems[link] with the text you want to cache...
      cachedItems[link] = bla...
    end
    -- Save the link so we can compare it with the next iteration
    lastLink = link
  end
  -- ...and always use cachedItems[link] at this point
  

  The beauty of this is that hovering over already cached items will read from the cache instead of computing again. If some scaling factor changes though, you could just easily clear the cache.

  The helpful people in #wowace on irc.freenode.net have again helped with the above code.

  Barf

  Last edited on 10 Nov 2009 by Barfolomeu
• 

  • #18

  tylerdurden2 Mon, 09 Nov 2009 00:45:52

  To keep you updated, I have now rewritten getItemSlotValue with the following:

  • All lua functions are now first declared file local (ie local find = find)
  • All splits have been replaced with selects
  • The tooltip parsing is now only used for the gem management, I get all the item stats from GetItemStats. This includes the inner tooltip parse used to compute the amount of sockets on an item, that has now been removed.

  The frame drop seems gone, but on my pc it was marginal before too. I ran the optimizer, it tested 720 combinations in 14 seconds pre changes, and 9 seconds post changes.

• 

  • #17

  tylerdurden2 Sun, 08 Nov 2009 17:56:01

  No harm done, I welcome constructive criticism. I'll surely poke you, in the meantime I have the following questions/comments:

  Quote:

  Create local copies of functions. This is a known caveat of lua. For example: local fnd = string.find (and replace all occurrences of string.find with fnd)

  Nice, didn't know that. I'm not 100% sure of the scope though. Do you mean "file" local functions?

  Quote:

  Instead of using strsplit, which is an expensive operation:

  if (string.find(text, "^%+%d+ Ausdauer") ~= nil and r+b ~= 0) then
    stamina, token1 = strsplit(" ", text, 2)
    trash, stamina = strsplit("+", stamina, 2)
  end
  

  Do this instead:

  stamina = select(3, fnd(text, "^%+(%d+) Ausdauer"))
  

  Better yet, use GetItemStats(item). There's no need to parse the text of each item's tooltip, and per locale no less, to get what you want.

  I understand the first part, but I must say I'm curious about where the GetItemStats came from. It's not on my book, nor on wowwiki, is it very recent? I also imagine two scenarios by swapping to it. Will it include the enchantment stats? If yes, I might have to model all enchantments and remove their contribution, which will be pretty bad. I also imagine that I'll need to keep the way gem scanning works now to be able to keep using the "virtual" fillers. The repeated function in the different locales was because I not only had the issue of what to string.find or string.split, but also because in one language I might have needed to do a select(2 ....) and in another select(4 ... ) since the number I wanted could be placed in a different position based on the locale. That would have generated an enormous amount of if - else in the "general" function.

  Quote:

  Finally, cache the text you add to the tooltip on the first iteration so that you only generate it once, then use that cached text on each iteration of ontooltipsetitem.

  Can you elaborate on this a bit? How do I cache it exactly? I need a way that, if for example I change a gem of choise in the rhadatip gem tab, will not use the cached value but recompute it. Same if I gem the item and so on so forth.

  Thanks for the help, Rhad

  EDIT: I was just able to log, apparently GetItemStats ignores gems and enchantments completely, even if the passed itemlink is gemmed and enchanted. I guess that means that I can use it without the hassle of the enchantments.

  Last edited on 08 Nov 2009 by tylerdurden2
• 

  • #16

  Barfolomeu Sat, 07 Nov 2009 02:21:05

  I love the concept of your addon, but I must say, after having looked at the code, there's only one word that describes it: horrible.

  Sorry to be so blunt, but the truth hurts some times. The addon causes massive performance issues for me. Here are a few suggestions to make your addon better:

  Create local copies of functions. This is a known caveat of lua. For example:

  local fnd = string.find (and replace all occurrences of string.find with fnd)

  Use locale files strictly for locale variables. L["foo"] = "foozen", and make that huge function exist in only one place, using locale variables.

  Instead of using strsplit, which is an expensive operation:

  if (string.find(text, "^%+%d+ Ausdauer") ~= nil and r+b ~= 0) then
    stamina, token1 = strsplit(" ", text, 2)
    trash, stamina = strsplit("+", stamina, 2)
  end
  

  Do this instead:

  stamina = select(3, fnd(text, "^%+(%d+) Ausdauer"))
  

  Better yet, use GetItemStats(item). There's no need to parse the text of each item's tooltip, and per locale no less, to get what you want.

  Finally, cache the text you add to the tooltip on the first iteration so that you only generate it once, then use that cached text on each iteration of ontooltipsetitem. Yes, the blizzard UI iterates over the tooltip in your character sheet and bags for every onUpdate event, to account for cooldowns.

  If you'd like some specific help with the issues I've mentioned, I'd be glad to help. Send me a message on the site and we can set something up.

  BTW, the great vhaarr from #wowace on irc.freenode.net is the one that suggested all this and I just parrotted what he wrote, but my offer of help still stands.

  Barf

  Last edited on 07 Nov 2009 by Barfolomeu
• 

  • #15

  tylerdurden2 Wed, 26 Aug 2009 08:24:27

  True. The problem is, autobar has been discontinued as far as I could read around.

  I've posted the issue in the wowace forum, autobar thread, but there is no news yet.

  Last edited on 25 Sep 2009 by tylerdurden2
• 

  • #14

  slickwalker Wed, 26 Aug 2009 01:10:33

  Causes weird things to happen with autobar. Bars dont appear for some reason.

• 

  • #13

  tylerdurden2 Sun, 02 Aug 2009 22:51:54

  Thanks for the kind words. I promise that once I'm done fixing 3.2 stuff (and tonight I added all the gems, so basically it's only trinkets missing, but those still have "colosseum 5 men" kind of names on wowhead) I'll get myself into localization. It isn't that easy since tooltip parsing is strictly based on wordings, which are of course heavily dependant of the language. Do you think that I could contact you in a while to be the french supporter of the localization? :p

• 

  • #12

  Gennoken Sat, 01 Aug 2009 22:16:59

  Best Gear DPS addon but i still can't use it :( it's not working with french client :(

• 

  • #11

  tylerdurden2 Fri, 10 Jul 2009 15:39:06

  Version 2.0.8 is incomplete but solves the auctionator bug. PM me if you want to use it.