271 - 4.0.1 exports to enhsim
*The two end enh talents (maelstrom and imp. ll) were not exported because of a typo, correct line 375 with 17, 18 instead of 27, 28 :
_, _, _, _, currRank, maxRank = GetTalentInfo(2,17) -- Maelstrom Weapon
self:AddLine("maelstrom_weapon "..currRank.."/"..maxRank)
_, _, _, _, currRank, maxRank = GetTalentInfo(2,18) -- Imp.Lava Lash
self:AddLine("improved_lava_lash "..currRank.."/"..maxRank)
*I have tweaked melee hit too, line 94 because Ziff integrated the 6% hit from talent in EnhSim (so that stats = paperdoll) :
percentage = GetCombatRatingBonus(6) -- Melee Hit rating
self:AddLine("mh_hit "..format("%.2f",percentage+6))
self:AddLine("oh_hit "..format("%.2f",percentage+6))
----
* ashen verdict (ring_proc) isn't detected but the code looks good (I dont know lua…)
* gloves/cloak enchant are detected even if not “special” (and not recognised by Enhsim but we don't really care)
* weapon type might be easy to detect (to code)
* + glyphs to work to finish the export fully
- 2 comments
- 2 comments
Facts
- Last updated
- Nov 07, 2010
- Reported
- Oct 29, 2010
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- Medium - Normal priority.
- Votes
- 0
Reported by
Possible assignees
-
- Manager
- Author
-
- Author
-
- Author
- Reply
- #2
Pericles Nov 07, 2010 at 19:55 UTC - 0 likesimplemented for v6.1 needs testing
- Reply
- #1
Pericles Oct 29, 2010 at 13:04 UTC - 0 likesI've just coded a fix for MW & Imp.LL + hit rating. Your fix for melee hit rating is wrong as it would give too high a value for Elemental Shaman. It should only add the 6% if the Shaman is in Enhancement Spec. NB. The sim supports both specs now.
Rings/Gloves/Cloak enchants have changed and I need to work out how they have changed.
Weapon Type should have an API, I'll investigate.
Glyphs they are all over the shop so I need to re-factor this section to give proper results, it's a bigger effort so I didn't tackle that yet.