26 - TipTac resizes itself
I have created two screenshots to demonstrate the problem.
When i first hover my mouse over an creature i will get this:
http://imgur.com/WqDvw.jpg
1-2 seconds later it will resize itself to the right size:
http://imgur.com/mlwGv.jpg
I don't know what is causing this problem, but it's annoying.
| User | When | Change |
|---|---|---|
| Aezay | Nov 26, 2010 at 11:45 UTC | Changed status from Started to Waiting |
| Aezay | Nov 20, 2010 at 14:08 UTC | Changed status from Replied to Started |
| AtliThor | Nov 20, 2010 at 01:55 UTC | Changed status from Waiting to Replied |
| Aezay | Nov 19, 2010 at 08:19 UTC | Changed status from Replied to Waiting |
| Paprika | Nov 10, 2010 at 14:01 UTC | Changed status from Waiting to Replied |
| Aezay | Oct 30, 2010 at 06:33 UTC | Changed status from Replied to Waiting |
| Paprika | Oct 27, 2010 at 18:07 UTC | Changed status from Waiting to Replied |
| Aezay | Oct 19, 2010 at 20:15 UTC | Changed status from Replied to Waiting |
| Paprika | Oct 08, 2010 at 15:50 UTC | Changed status from Waiting to Replied |
| Aezay | Oct 04, 2010 at 11:06 UTC | Changed status from New to Waiting |
| Paprika | Sep 25, 2010 at 12:14 UTC | Added attachment error_tiptac.gif |
| Paprika | Sep 25, 2010 at 12:11 UTC | Create |
- Reply
- #13
Aezay Nov 26, 2010 at 11:45 UTC - 0 likesDid some more testing, and I think the issue might be how I in TipTac set the height of the GTT in its Show() hook. I commented this out and let the OnUpdate script handle all resizing and that also seem to have fixed it. But I am afraid this might have broken something else, as I seem to remember I put the resizing code into the Show() hook for a reason.
- Reply
- #12
Aezay Nov 26, 2010 at 11:23 UTC - 0 likesBeen looking over the code and there is one thing I have a hard time understanding.
When the GTT:OnShow() script hook code in "XToLevel" adds its text to the tooltip, it finished off by calling GTT:Show() as that forces the tooltip to recalculate its height. The GTT:Show() function is hooked by TipTac, so it can recalculate the new height also, which is (GTT:GetHeight() + bars.offset).
What I cannot understand, is how the call to GTT:Show() in XToLevel, doesn't seem to make TipTac recalculate its height.
The code you posted AtliThor works, and I will probably go with that fix. It would however just be great if I could understand exactly why this is happening.
- Reply
- #11
Aezay Nov 20, 2010 at 14:08 UTC - 0 likesAlright, thanks. Will look at applying your fix then.
- Reply
- #10
AtliThor Nov 20, 2010 at 01:55 UTC - 0 likesI've tested this with 4.0.3 and the issue is still present. The added line from my XToLevel hook causes a margin until the next Show tick. The patch I suggested still fixes it though.
- Reply
- #9
Aezay Nov 19, 2010 at 08:19 UTC - 0 likesThanks for the feedback.
I've heard of an issue in the 4.0.1 patch which could cause some flickering to happen, this issue was fixed in 4.0.3. Now I wonder if this fixed this issue with TipTac, or is it still present?
Also, thanks for the code AtliThor, I will keep this in mind if this is still an existing issue.
I've tried to make sure TipTac is the last addon to hook the tooltip functions, but that is an almost impossible task, so this might be a better fix.
- Reply
- #8
AtliThor Nov 12, 2010 at 16:31 UTC - 0 likesHey.
I believe I have identified the cause of this problem.
In TipTac's "gtt.Show" function, the height of the tooltip is calculated and set. And in the OnUpdate hook, the value of the height set in "gtt.Show" is compared to the actual height, and if different, is supposed to be updated. - I assume this is done to resize the tooltip to fit the custom status bars when the tooltip is modified by foreign code between the "gtt.Show" ticks.
This, however, does not work. The "new" height is simply set to the height calculated in the OnShow hook, so any OnShow hooks from other addons executed after TipTac's will cause an issue like this.
I assume you meant to recalculate the size in the OnUpdate hook. Doing that seems to fix this problem. - This has been working for me: (Starting from line #897 in core.lua)
This doesn't appear to mess up anything else. Nothing I can see, at least :)
- Reply
- #7
Paprika Nov 10, 2010 at 14:22 UTC - 0 likesSir, you won the prize. It's this addon: http://wow.curse.com/downloads/wow-addons/details/xto-level.aspx
- Reply
- #5
Aezay Oct 30, 2010 at 06:32 UTC - 0 likesYour tooltip shows "Kills to level: x", I would start checking that addon.
- Reply
- #4
Paprika Oct 27, 2010 at 18:07 UTC - 0 likesYou missunderstood me. I don't want you to tell me which addon is messing with the tooltip, that's the part i have to figure out. But maybe there is some kind of logfile/addon that helps me finding the issue. Something that tells me: "Hey, these addons are affecting the Tooltip in whatever way".
- Reply
- #3
Aezay Oct 19, 2010 at 20:15 UTC - 0 likesI cannot tell you which addon is causing these issues, you'll have to narrow that down yourself. Once you find the name of the addon causing this, I can take a look and see why its happening.