14 - Fix logging in while mounted
What does the provided patch do?
Fix the bug when logging in while mounted.
Please provide any additional information below.
Seems the event ADDON_LOADED no longer carries an argument stating *which* addon was loaded.
Fast workaround: on line of TitanMount.lua remove the 'and arg1 == "TitanMount"' so that the line reads:
if event == "ADDON_LOADED" then
Full patch that also gracefully fails on similar problems:
Index: TitanMount.lua
===================================================================
--- TitanMount.lua (revision 13)
+++ TitanMount.lua (working copy)
@@ -137,6 +137,7 @@
elseif mountNumber ~= nil then mountName, mountIcon = GetMountInfo()
-- Mounted, but not cached
else mountName, mountIcon = GetCurrentMount()
+ if mountName == nil then mountName = "Could Not Determine" end
end
if IsOutdoors() == nil then
mountColor = MountC5
@@ -347,7 +348,7 @@
end
function TitanPanelMountButton_OnEvent(event, arg1)
- if event == "ADDON_LOADED" and arg1 == "TitanMount" then
+ if event == "ADDON_LOADED" then
mountNumber = mountNumberOver
mountSpell = mountSpellOver
end
| User | When | Change |
|---|---|---|
| Suddendeath2000 | Nov 30, 2010 at 21:41 UTC | Changed status from Started to Fixed |
| Suddendeath2000 | Nov 30, 2010 at 21:35 UTC | Changed status from New to Started |
| CMTitan | Nov 02, 2010 at 19:16 UTC | Create |
- 2 comments
- 2 comments
Facts
- Last updated
- Nov 30, 2010
- Reported
- Nov 02, 2010
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Patch - Source code patch for review
- Priority
- Medium - Normal priority.
- Votes
- 0
Reported by
Possible assignees
-
- Manager
- Author
- Reply
- #2
omgitslogan Nov 15, 2010 at 13:44 UTC - 0 likesI don't have any software to edit the lua for this so I would really like it if the creator just patched this issue.
- Reply
- #1
Goranth Nov 09, 2010 at 14:27 UTC - 0 likesmy confusion with this is do I just replace that one line, or do I patch and replace those blocks of code. I dont wanna mess anything up, but would like the most complete solution. I am going to start with just the one line, but more instruction/clarification would be appreciated.