21 - Menu for selecting the default channel for broadcasting by left-clicking (see ticket 9)
I didn't like the automatic broadcast to Guild when I left-click the addon, especially since I don't want the broadcasting features at all and I tend to accidently click on addons. Also, I noticed that one can't set the default channel right now, but it is an option internally.
So, I've built the menu for that.
Attached you'll find the diff against the current release (1.1.5). Also, in diffFull, you'll find both this feature and the 'Show Seconds' feature, which I developed simultaneously (see ticket 22).
| Name | Size | MD5 |
|---|---|---|
| diffDefaultChannel | 2.7 KiB | f53de6d13aab... |
| diffFull | 3.4 KiB | 65146ceae40b... |
| User | When | Change |
|---|---|---|
| Rothpada | Nov 10, 2009 at 18:54 UTC | Changed status from Started to Fixed |
| Rothpada | Nov 09, 2009 at 01:53 UTC | Changed status from Accepted to Started |
| Rothpada | Nov 09, 2009 at 01:30 UTC | Changed status from New to Accepted |
| CMTitan | Aug 29, 2009 at 00:31 UTC | Added attachment diffFull |
| CMTitan | Aug 29, 2009 at 00:31 UTC | Deleted attachment diffFull: Made an error with the show seconds feature. Fixed in new diff. |
| CMTitan | Aug 29, 2009 at 00:18 UTC | Changed description:So, I've built the menu for that. - Attached you'll find the diff against the current release (1.1.5). Also, in diffFull, you'll find both this feature and the 'Show Seconds' feature, which I developed simultaneously. + Attached you'll find the diff against the current release (1.1.5). Also, in diffFull, you'll find both this feature and the 'Show Seconds' feature, which I developed simultaneously (see ticket 22). |
| CMTitan | Aug 29, 2009 at 00:14 UTC | Added attachment diffFull |
| CMTitan | Aug 29, 2009 at 00:14 UTC | Changed description:So, I've built the menu for that. + Attached you'll find the diff against the current release (1.1.5). Also, in diffFull, you'll find both this feature and the 'Show Seconds' feature, which I developed simultaneously. - Below is the diff to the current release (1.1.5). Note that I simultaneously implemented the 'Show Seconds' option. For a diff containing both features, please see the ticket for that. - - - - diff -rw TitanWG/Localization.lua TitanWGDefaultChannel/Localization.lua - 49a50,52 - > - > L["TITAN_WG_DEFAULT_CHANNEL"] = "Default channel for broadcasts"; - > L["TITAN_WG_NONE"] = "None" - diff -rw TitanWG/TitanWG.lua TitanWGDefaultChannel/TitanWG.lua - 312c312,315 - < TitanWG_postTimeToChannel(TitanGetVar(TITAN_WG_ID, "DefaultChannel")); - --- - > local channel = TitanGetVar(TITAN_WG_ID, "DefaultChannel"); - > if channel ~= "NONE" then - > TitanWG_postTimeToChannel(channel); - > end - 475a479,518 - > elseif ( UIDROPDOWNMENU_MENU_VALUE == "TITAN_WG_DEFAULT_CHANNEL" ) then - > info = {}; - > info.text = L["TITAN_WG_SAY"]; - > info.func = function() TitanSetVar(TITAN_WG_ID, "DefaultChannel", "SAY"); end - > info.notCheckable = false; - > info.checked = function() return TitanGetVar(TITAN_WG_ID, "DefaultChannel") == "SAY"; end - > UIDropDownMenu_AddButton(info,2); - > info = {}; - > info.text = L["TITAN_WG_YELL"]; - > info.func = function() TitanSetVar(TITAN_WG_ID, "DefaultChannel", "YELL"); end - > info.notCheckable = false; - > info.checked = function() return TitanGetVar(TITAN_WG_ID, "DefaultChannel") == "YELL"; end - > UIDropDownMenu_AddButton(info,2); - > info = {}; - > info.text = L["TITAN_WG_GUILD"]; - > info.func = function() TitanSetVar(TITAN_WG_ID, "DefaultChannel", "GUILD"); end - > info.notCheckable = false; - > info.checked = function() return TitanGetVar(TITAN_WG_ID, "DefaultChannel") == "GUILD"; end - > UIDropDownMenu_AddButton(info,2); - > info = {}; - > info.text = L["TITAN_WG_PARTY"]; - > info.func = function() TitanSetVar(TITAN_WG_ID, "DefaultChannel", "PARTY"); end - > info.notCheckable = false; - > info.checked = function() return TitanGetVar(TITAN_WG_ID, "DefaultChannel") == "PARTY"; end - > UIDropDownMenu_AddButton(info,2); - > info = {}; - > info.text = L["TITAN_WG_RAID"]; - > info.func = function() TitanSetVar(TITAN_WG_ID, "DefaultChannel", "RAID"); end - > info.notCheckable = false; - > info.checked = function() return TitanGetVar(TITAN_WG_ID, "DefaultChannel") == "RAID"; end - > UIDropDownMenu_AddButton(info,2); - > - > TitanPanelRightClickMenu_AddSpacer(2); - > - > info = {}; - > info.text = L["TITAN_WG_NONE"]; - > info.func = function() TitanSetVar(TITAN_WG_ID, "DefaultChannel", "NONE"); end - > info.notCheckable = false; - > info.checked = function() return TitanGetVar(TITAN_WG_ID, "DefaultChannel") == "NONE"; end - > UIDropDownMenu_AddButton(info,2); - 490a534,538 - > info = {}; - > info.text = L["TITAN_WG_DEFAULT_CHANNEL"]; - > info.value = "TITAN_WG_DEFAULT_CHANNEL"; - > info.hasArrow = 1; - > UIDropDownMenu_AddButton(info); |
| CMTitan | Aug 29, 2009 at 00:13 UTC | Added attachment diffDefaultChannel |
| CMTitan | Aug 29, 2009 at 00:12 UTC | Create |
- 1 comment
- 1 comment
- Reply
- #1
Rothpada Nov 09, 2009 at 01:54 UTC - 0 likesI've incorporated your changes. I still need to test them (I'm on a linux laptop without wow installed) but they look great so far. Thanks a ton for doing that!!