CurseForge.com

AuctionMaster

98 - AuctionMaster causes taint

First: I know that there have been other similar reports and that you said that it's not the fault of AuctionMaster, but please read on!

What steps will reproduce the problem?
1. Optional step: Make sure that AuctionMaster is the only enabled addon.
2. Do the daily quest Riding the Storm. There are other ways to reproduce it but this one is the easiest I know.
3. Use the quest item to get on a mob.
4. Attack it a few times.
5. Use the leave vehicle button.

What is the expected output? What do you see instead?
The message "Interface action blocked by addon" is shown. If you have BugGrabber installed, it will show the error directly, otherwise you can use /console taintLog 2 before to get it written to the file taint.log.

What version of the product are you using?
5.2.0

Do you have an error log of what happened?
11/18 13:18:54.696 An action was blocked in combat because of taint from AuctionMaster - CompactRaidFrame1:Show()
11/18 13:18:54.696 Interface\FrameXML\CompactUnitFrame.lua:276 CompactUnitFrame_UpdateVisible()
11/18 13:18:54.696 Interface\FrameXML\CompactUnitFrame.lua:234 CompactUnitFrame_UpdateAll()
11/18 13:18:54.696 Interface\FrameXML\CompactUnitFrame.lua:96

Please provide any additional information below.
The fact that this taint also happens if AuctionMaster is the only enabled addon clearly shows that there must be something in AuctionMaster that affects the CompactRaidFrames. AuctionMaster doesn't have to call the function itself to cause this error. As soon as the Blizzard code uses any tainted variable it will fail. Most likely AuctionMaster causes this error because it sets (and therefore taints) many global variables with common names (e.g. frame, height, slot, bag, now, bt). I assume one of this variables is then used by Blizzard code which causes the taint error.

I've attached a file that lists all global variables that are set by AuctionMaster. If you want to check your code yourself I suggest to use either FindGlobals or the Wow Global Finder GUI wrapper for it.

Name Size MD5
setglobals.txt 5.7 KiB 904bc61eeded...
User When Change
Udorn Dec 27, 2012 at 15:56 UTC Changed status from Accepted to Fixed
Udorn Nov 18, 2012 at 16:20 UTC Changed status from New to Accepted
cremor Nov 18, 2012 at 13:19 UTC

Added attachment setglobals.txt
cremor Nov 18, 2012 at 13:19 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 7 comments
  • Avatar of Udorn Udorn Dec 27, 2012 at 15:56 UTC - 0 likes

    Hi cremor,

    great to hear that. :-) Thank you very much for your support.

  • Avatar of cremor cremor Dec 27, 2012 at 15:52 UTC - 0 likes

    I didn't try that one daily since I don't do that dailies any more, but I've done some LFR raids and didn't get any error. Seems like it is fixed :-)

  • Avatar of cremor cremor Dec 26, 2012 at 17:57 UTC - 0 likes

    Glad to hear that. I'll try it for some time and will report back in some days.

  • Avatar of Udorn Udorn Dec 26, 2012 at 11:09 UTC - 0 likes

    I have now replaced all usages of Blizzard's UIDropdown button code and can't reproduce the error with my hunter anymore. It's released as alpha version 5.5.0-RC1.

  • Avatar of Udorn Udorn Dec 23, 2012 at 12:02 UTC - 0 likes

    It seems to be reproducable with hunters taming a pet. If done just after entering the WoW-Client the Lua-error occurs. After the first reload, the error doesn't occur anymore, I have to restart the client to see the error again. Very mysterious...

  • Avatar of cremor cremor Nov 23, 2012 at 18:01 UTC - 0 likes

    It seems like my assumption was wrong. Version 5.2.1-RC1 still contains two global sets that are most likely unwanted, but even after fixing these the taint problem is still there. So it seems like something different in AuctionMaster is causing it. Sadly I've no idea how that could be debugged.

    These are the still existant global sets:

    function <C:\Spiele\World of Warcraft\Interface\AddOns\AuctionMaster\src\main\Gui\\AceGUIWidget-ScrollableSimpleHTML.lua:45,55> (27 instructions, 108 bytes at 0045E630)
	[47]	SETGLOBAL	1 -1	; onVertScroll
function <C:\Spiele\World of Warcraft\Interface\AddOns\AuctionMaster\src\main\Scanner\\Scanner.lua:465,497> (133 instructions, 532 bytes at 0030B088)
	[475]	SETGLOBAL	30 -11	; unknown
  • Avatar of Udorn Udorn Nov 18, 2012 at 16:19 UTC - 0 likes

    Hi Cremor,

    thanks a lot for this detailed bug-report. I thought it was caused by another addon, because I also get this error message when I deactivate AuctionMaster. Once I tried to hunt the causer, but after having deactivated the fifth addon I gave up. ;-)

    But your oberservations may lead to the idea, that ALL addons are causing this error. So I will look again, in the hope that at least AuctionMaster is not among the addons causing this kind of errors.

    The "unwanted" globals will all be removed. Everything should be in the "vendor" namespace, if it's not one of the few API functions.

  • 7 comments

Facts

Last updated
Dec 27, 2012
Reported
Nov 18, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees