You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #10

  eridius Feb 17, 2013 at 07:01 UTC - 0 likes

  gitignore doesn't ignore changes to existing files. I can use the assume-unchanged bit, but it's not really designed for this. What do you personally do?

  For the syntax issue, my recommendation would be to change the locale files to look like

  local _, addonTable = ...
  addonTable.LOCALE["enUS"] = {}
  local L = addonTable.LOCALE["enUS"]
  
  --@localization(locale="enUS", format="lua_additive_table")@
  

  This way it will be syntactically correct without keyword substitution, and will insert the localizations into the L table when packaged.

  In order to actually have good values without keyword substitution as well, you might have a default_enUS.lua file that contains a dump of the current English translations, and edit locale.xml to have

  <!--@debug@--><Script file="default_enUS.lua"/><!--@end-debug@-->
  

  Load this as the first locale, and it will be skipped during packaging.

  And then for the other locales, after the --@localization line you can add

  setmetatable(L, { __index = addonTable.LOCALE["enUS"] })
  

  instead of using the handle-unlocalized="english" command. This will have the same effect except it will work when there's no keyword substitution.

  Last edited Feb 17, 2013 by eridius: Fix the format of the localization
• 

  • Reply
  • #9

  AtliThor Feb 17, 2013 at 06:30 UTC - 0 likes

  Hey eridius.

  I would simply set up a gitignore file on my local clone of the repo to ignore changes to the localization files and then overwrite them with copies from the latest version from the site.

  As for the globals. Thanks for the suggestion. I truthfully never gave it much thought. This was just an obvious way to do what I needed, and I've never had any problems with it.

• 

  • Reply
  • #8

  eridius Feb 17, 2013 at 06:04 UTC - 0 likes

  I tried checking out the git repo for this project, but because of the way localizations work, all the locale files are invalid (since they require the repository keyword substitution to become valid). How do you deal with that?

  Also, you seem to be stuffing the locale info into two global variables named L and LOCALE. This is a really bad idea. You should put these into the addon-specific table (the second arg passed to each lua file) instead.

• 

  • Reply
  • #7

  AtliThor Jan 28, 2011 at 17:55 UTC - 0 likes

  Hey dakar.

  Sure that shouldn't be much trouble. I'll try to add that as soon as I can.

  Thanks :)

• 

  • Reply
  • #6

  dakar2008 Jan 28, 2011 at 07:38 UTC - 0 likes

  Hi AtliThor, do you think it would be possible to add a button to reset gathering data also, like for dungeon and mobs, and maybe a counter for when you pickup Archaeology fragments, like when you pickup Herbs, so i can track how many pickup's i need to lvl my character, by the way great addon you done there m8.

  Best Regards.

  Begnar @ EU-Runetotem

• 

  • Reply
  • #5

  skelgaard Oct 27, 2010 at 09:31 UTC - 0 likes

  well now i'm raiding quite a bid on my hunter and therefor it "bugs" me a little to see the text disabled in the bar, but don't wanna run 4 different addon profiles, if i don't have to

• 

  • Reply
  • #4

  AtliThor Oct 26, 2010 at 17:00 UTC - 0 likes

  In version 4.0.1_19 you should be able to uncheck the "Enabled" box at the top of the LDB Configuration tab to disable the LDB sources entirely. You should also be able to disable both the Window and Messages in their respective configuration tabs.

  I'll see if I can make this a bit more automated in the next release. To be honest I never really payed much attention to what happened after chars reached 80. I usually just move onto my next alt when that happens :)

  Could take me a little time. I've got a busy week ahead of me in RL.

• 

  • Reply
  • #3

  skelgaard Oct 25, 2010 at 20:31 UTC - 0 likes

  i have a hunter my selves... and it its fine it stays active, if it it then just removed all text and only was an icon, so it fills as little as possible then. or had an option for this. like "remove all text, if no leveling is possible"

  Last edited Oct 25, 2010 by skelgaard
• 

  • Reply
  • #2

  AtliThor Oct 24, 2010 at 16:43 UTC - 0 likes

  Hey skelgaard.

  The reason why I keep the Addon active for level 80 chars is so hunters can use it to level their pets. - I should be able to disable it, or at least the LDB source, for other classes though. I'll look into it.

  Thanks ;)

• 

  • Reply
  • #1

  skelgaard Oct 23, 2010 at 12:16 UTC - 0 likes

  i like this addon alot, but in chokolade bars, but instead of writing disabled on a level 80, couldn't you just remove the text or disable the addon, if no level is possible ?