GoGoMount

838 - Druid Travel Form Problems.

I don't have a sub right now, so I can only test with level 20 characters, max riding skill of Apprentice (+60%). I don't have access to a guild, so I can't test with +70% riding.

Problem: Travel Form is selected over any ground mounts when Feline Swiftness talent is selected.
Cause: Feline Swiftness talent is getting calculated incorrectly.
File GoGoMount.lua, lines 3336 and 3337.
Currently says Cat Form is 144% speed while my stat sheet says 145% speed (pedantic note, probably affects nothing).
Same file, lines 3338 and 3339.
Currently says Travel Form is 161% speed while my stat sheet says 155% speed. This means it will always select the 161% Travel Form over all my 160% ground mounts.

Solution: Change line 3338 to
GoGo_Variables.MountDB[GoGo_Variables.Localize.TravelForm][10002] = 155
and change line 3339 to
GoGo_TableAddUnique(GoGo_Variables.GroundSpeed, 155)

Notes:
1. I don't have access to my glyphs pane at level 20, but Glyph of Travel increases travel form speed to 100%. I don't see anywhere in the current code that checks for this, but I could be missing it. If I'm not missing it, that should probably be another ticket. The glyph requires level 25 so I can't test it.
2. I think the speed used to be correct, then the WoD changes made it wrong. Pre-WoD, movement bonuses were multiplicative. So 15% extra speed meant BaseSpeed*1.15. Travel Form is a 40% increase, or 1.4 total, so 1.4 * 1.15 = 1.61 or 161%. In WoD, bonuses are additive. So 15% extra speed means BaseSpeed+0.15. Travel form is 1.4, so 1.4+0.15 = 1.55 or 155%.
3. If that's the issue, then it will be the case for a number of other things too. I made a spreadsheet and sorted by speeds, and there are a few places where the order changes.

Old: Travel+0% < Cat+10% (140% < 143%)
New: Travel+0% = Cat+10% (140% = 140%)
I don't think there's a 10% buff that applies to Cat but not Travel form, so this doesn't matter. Plus, the old setting wouldn't be slowing you down anyways.

Old: Travel+10% < Cat+20% (154% < 156%)
New: Travel+10% = Cat+20% (150% = 150%)
I don't think Cat+20% is possible at all, so this is probably meaningless. And, again, it's not slowing you down, just limiting a form. Edit: More importantly, the +20% would probably apply to Travel Form too, so it wouldn't matter.

Old: Apprentice+0% < Travel+15% < Travel+20% (160% < 161% < 168%)
New: Travel+15% < Travel+20% = Apprentice+0% (155% < 160% = 160%)
As above, I don't think Travel+20% is possible, so that change isn't important. However the Travel+15% change is important and is the topic of this ticket. Edit: As noted in a follow-up comment, Travel+25% may be possible, and is also important.

Old: Master+0% < Artisan+10% < Artisan+15% < Master+10% < Artisan+20% (410% < 418% < 437% < 451% < 456%)
New: Artisan+10% < Artisan+15% < Artisan+20% < Master+0% < Master+10% (390% < 395% < 400% < 410% < 420%)
These changes don't matter for two reasons: first, all flying mounts scale with flight speed, so you'd never pick between artisan and master speeds; second, whatever is giving you a +10%/15%/20% buff would apply to either an artisan or master mount.

The bottom line is that as far as I can see, only the changes to travel form with nature's swiftness make a practical difference, even if some numbers may be technically wrong somewhere in the code (assuming you ever bothered to calculate all this stuff in the first place). Note, however, "as far as I can see". It's quite possible I missed some other combination of effects.

Also, just wanted to say I love this addon, thanks very much for all your hard work keeping it going all these years!

User When Change
tiker Aug 12, 2015 at 15:21 UTC Changed status from New to Accepted
Vaerolaeli Jun 18, 2015 at 08:23 UTC Changed description:
  Old: Travel+10% < Cat+20% (154% < 156%)
  New: Travel+10% = Cat+20% (150% = 150%)
- [i]I don't think Cat+20% is possible at all, so this is probably meaningless. And, again, it's not slowing you down, just limiting a form.[/i]
+ [i]I don't think Cat+20% is possible at all, so this is probably meaningless. And, again, it's not slowing you down, just limiting a form. Edit: More importantly, the +20% would probably apply to Travel Form too, so it wouldn't matter.[/i]

  Old: Apprentice+0% < Travel+15% < Travel+20% (160% < 161% < 168%)
  New: Travel+15% < Travel+20% = Apprentice+0% (155% < 160% = 160%)
- [i]As above, I don't think Travel+20% is possible, so that change isn't important. However the Travel+15% change is important and is the topic of this ticket.[/i]
+ [i]As above, I don't think Travel+20% is possible, so that change isn't important. However the Travel+15% change is important and is the topic of this ticket. Edit: As noted in a follow-up comment, Travel+25% may be possible, and is also important.[/i]
  Old: Master+0% < Artisan+10% < Artisan+15% < Master+10% < Artisan+20% (410% < 418% < 437% < 451% < 456%)
  New: Artisan+10% < Artisan+15% < Artisan+20% < Master+0% < Master+10% (390% < 395% < 400% < 410% < 420%)
Vaerolaeli Jun 16, 2015 at 09:42 UTC Changed name from Druid Travel from Problems. to Druid Travel Form Problems.
Vaerolaeli Jun 16, 2015 at 09:40 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of tiker tiker Aug 12, 2015 at 15:28 UTC - 0 likes

    Thanks for all of the information.  I have not fully read all of your comments yet but I will when I get time to start updating the code with what I find.

    Up to now, I've determined the various numbers for speed using a mod that calculates the movement speed.  (This mod does the actual calculations based on the map's location coordinates and not from the movement speed APIs.)

    The druid speed related stuff was last updated with WoD beta.  Since I don't play a Druid I don't have an opportunity to test and update unless there's a PTR or Beta server available.  GoGoMount currently only checks the movement speed modifications from spells, buffs and talents.  Currently, GoGoMount does not check for Enchants.

    I do plan on making some major improvements over calculating movement speeds and plan on including enchants since travel forms are now improved by enchants as well.  This will take some time to complete.

    Want to chat? You'll find me here if I'm online:
    [email protected]
    (XMPP / Jabber Group Chat)

  • Avatar of Vaerolaeli Vaerolaeli Jun 18, 2015 at 08:20 UTC - 0 likes

    It looks like the Gift of <Stat> cloak enchants stack with Feline Swiftness (says the comment on the Gift of Mastery page). This means a 25% speed buff is possible in Cat Form and maybe Travel Form. Also, anything like Pandaren's Step stacks with the talent, but the different enchants don't stack with each other. So you'd need to check for different enchants, but not for combinations of enchants - just start with +10% speed, then work down if those aren't found.

    Comments on the Feline Swiftness page state the talent does *not* stack with Glyph of Aquatic Form or Glyph of Travel. Comments on the Mount Up page say the guild buff does *not* apply to Travel Form, so the following speeds should be possible:

    Run = Running on Foot, Cat = Cat Form, Trav = Travel Form, Gift = Gift Enchant (or equivalent), FeSw = Feline Swiftness Talent, GlTrav = Glyph of Travel, MntUp = Mount Up Guild Perk, StabPerk = Level 3 Stable Perk (or the Paladin or DK passives for comparison, although you can't have those and be a druid), Turtle = Sea Turtle or Riding Turtle, RegRide = Apprentice Riding (+60%) Mounts, FastRide = Journeyman Riding (+100%) Mounts.

    By absolute speed, ground:
    100% - Run
    110% - Turtle + MntUp
    110% - Run + Gift
    115% - Run + FeSw
    125% - Run + FeSw + Gift

    130% - Cat
    140% - Cat + Gift
    140% - Trav
    145% - Cat + FeSw
    150% - Trav + Gift
    155% - Cat + FeSw + Gift
    155% - Trav + FeSw
    160% - RegRide
    165% - Trav + FeSw + Gift
    170% - RegRide + MntUp
    180% - RegRide + StabPerk
    200% - Trav + GlTrav
    200% - FastRide
    210% - FastRide + MntUp
    220% - FastRide + StabPerk

    As above, most of the buffs will affect both Cat and Travel Forms, so you don't have to worry about Cat + FeSw > Trav and so forth. Of note, however:
    1. Running with Feline Swiftness is faster than a turtle, and with a 10% enchant is the same as a turtle, so you'd want to just keep running in those cases. Although I like the functionality that standing still and hitting my button will summon a random mount as long it's as the same speed as no mount or an instant mount (like I can already summon a gryphon while standing still instead of just always using swift flight form).
    2. Trav + FeSw + Gift is faster than RegRide, like Trav + FeSw used to be, so you'd want to use Travel Form instead of mounting in that case.
    3. Trav + GlTrav is the same speed as FastRide, but instant-cast, so you're better off with Travel Form than mounting, unless you have the guild perk, or are in Draenor with a level 3 stable (or are somehow a pally/DK with access to Travel Form :/).

    Swim = Swimming like normal, GlAq = Glyph of Aquatic Form.

    By absolute speed, water:
    67% - Swim
    77% - Swim + Gift
    101% - Trav
    108% - Turtle
    111% - Trav + Gift
    135% - Trav + GlAq
    145% - Trav + Gift + GlAq

    Starter accounts can't trade or browse the AH and you need level 25 for the glyph, so I can't test the enchant or glyph. I'm assuming the +10% is additive and works in water. Feline Swiftness doesn't affect swimming speed or water travel form. The guild and stable buffs shouldn't affect the turtle's swimming speed, but I can't test that. In this case, the noteworthy buff is that Travel Form with either an enchant or the glyph are faster than the sea turtle. I don't know if this is being taken into account already or not, but we should always use Travel Form over the turtle if there's a buff. If the enchant doesn't work for swimming then we would only care about the glyph.

    One last point to consider is the Speed tertiary stat. As far as I know it only affects running speed, and therefore things like Cat Form and Travel Form, but not ground or flying mounts. I'm not sure how much you can stack, but as little as 5% would make Travel Form with Feline Swiftness as fast as a regular mount, and 5% with the talent and a Gift enchant would put it on par with a ground mount and the Mount Up perk. 7% puts regular Travel Form on par with a turtle in the water (if Speed affects swimming), and 10% could put Glyphed Travel Form on par with epic ground mounts with the guild perk. 15% puts Travel Form with the enchant and talent on par with regular ground mounts and the stable perk (although it's highly unlikely anyone would still have regular riding and a level 3 stable), and 20% puts glyphed Travel Form as fast as an epic ground mount with the stable perk (or a DK/Pally).

  • Avatar of Vaerolaeli Vaerolaeli Jun 16, 2015 at 09:42 UTC - 0 likes

    Misspelled the title. Derp.

  • 3 comments

Facts

Last updated
Aug 12, 2015
Reported
Jun 16, 2015
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees