PetJournal Enhanced

117 - List sorting does not refresh when closing and re-opening pet journal

I don't know whether Curse sends notifications for replies to closed tickets, so I'm just opening a new one to let you know that the issue I reported in ticket #115 is not resolved by closing and re-opening the pet journal, as you said it should be when you closed that ticket.

You can easily verify this by adding a debug print in Sorting.lua:

    function Sorting:SortPets() print("PetJournalEnhanced: SortPets")

Opening the pet journal does not trigger a sort.

To resolve this, I added an OnShow script to the list scroll frame in HookedFunctions.lua:

    self.listScroll = CreateFrame("ScrollFrame","PetJournalEnhancedListScrollFrame",PetJournal,"HybridScrollFrameTemplate")
+   self.listScroll:HookScript("OnShow",function() Sorting:SortPets() end)

It sorts twice the first time it's shown, so there may some better place to invoke the sort, but I'll leave that up to you.

User When Change
Phanx Feb 07, 2015 at 10:53 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Reported
Feb 07, 2015
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees